Distingush between displayed and remote playback state.

Distingush between displayed and remote playback state.

Fixes two of the problems causing bug 593669.

distinguishes between the displayed playback state (which, for example
swiches to paused as soon as the pause button is pressed) and the
remote playback state. Hence avoids side effects when the only the
displayed playback state changes.

Also prevents pause being sent to Chromecast too early.

BUG=593669
Committed: https://crrev.com/829655949350c19eea8231f2e2da34679bc42d21
Cr-Commit-Position: refs/heads/master@{#383082}

[aberent, 2016-03-21 10:40:13]

For information only at present. This fixes the immediate failure to switch
videos (see the bug), but consistently leaves the new video paused when we do
switch.

My guess is that, now that I have solved the race conditions, the pause is
coming from https://bugs.chromium.org/p/chromium/issues/detail?id=595373;
however I have yet to fully verify this.

[aberent, 2016-03-21 10:43:23]

Description was changed from

==========
Distingush between displayed and remote playback state.

Fixes two of the problems causing bug 593699.

distinguishes between the displayed playback state (which, for example
swiches to paused as soon as the pause button is pressed) and the
remote playback state. Hence avoids side effects when the only the
displayed playback state changes.

Also prevents pause being sent to Chromecast too early.

BUG=593699
==========

to

==========
Distingush between displayed and remote playback state.

Fixes two of the problems causing bug 593669.

distinguishes between the displayed playback state (which, for example
swiches to paused as soon as the pause button is pressed) and the
remote playback state. Hence avoids side effects when the only the
displayed playback state changes.

Also prevents pause being sent to Chromecast too early.

BUG=593669
==========

[aberent, 2016-03-22 15:53:30]

aberent@chromium.org changed reviewers:
+ avayvod@chromium.org

[aberent, 2016-03-22 15:53:30]

Now ready for review, the pauses are being fixed by
https://codereview.chromium.org/1823983002/

[aberent, 2016-03-22 16:59:00]

The CQ bit was checked by aberent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 16:59:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822653002/20001

[commit-bot: I haz the power, 2016-03-22 18:33:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 18:33:33]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[whywhat, 2016-03-22 19:14:44]

lgtm

[aberent, 2016-03-22 20:16:26]

On 2016/03/22 19:14:44, whywhat wrote:
> lgtm

PTAL - new changes added.

[aberent, 2016-03-22 20:16:35]

The CQ bit was checked by aberent@chromium.org to run a CQ dry run

[aberent, 2016-03-22 20:16:45]

https://codereview.chromium.org/1822653002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerController.java
(left):

https://codereview.chromium.org/1822653002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerController.java:186:
if (controller.shouldResetState(player)) {
I don't think this test has been necessary at least since we moved the cast
controls into Blink. This test can only fail if Blink has got out of step with
cast, which can only happen with a bug.

[commit-bot: I haz the power, 2016-03-22 20:17:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822653002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822653002/40001

[commit-bot: I haz the power, 2016-03-22 21:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 21:03:43]

Dry run: This issue passed the CQ dry run.

[whywhat, 2016-03-24 16:26:52]

lgtm

[aberent, 2016-03-24 16:27:51]

The CQ bit was checked by aberent@chromium.org

[commit-bot: I haz the power, 2016-03-24 16:28:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822653002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822653002/40001

[commit-bot: I haz the power, 2016-03-24 17:07:12]

Description was changed from

==========
Distingush between displayed and remote playback state.

Fixes two of the problems causing bug 593669.

distinguishes between the displayed playback state (which, for example
swiches to paused as soon as the pause button is pressed) and the
remote playback state. Hence avoids side effects when the only the
displayed playback state changes.

Also prevents pause being sent to Chromecast too early.

BUG=593669
==========

to

==========
Distingush between displayed and remote playback state.

Fixes two of the problems causing bug 593669.

distinguishes between the displayed playback state (which, for example
swiches to paused as soon as the pause button is pressed) and the
remote playback state. Hence avoids side effects when the only the
displayed playback state changes.

Also prevents pause being sent to Chromecast too early.

BUG=593669
==========

[commit-bot: I haz the power, 2016-03-24 17:07:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-24 17:09:39]

Description was changed from

==========
Distingush between displayed and remote playback state.

Fixes two of the problems causing bug 593669.

distinguishes between the displayed playback state (which, for example
swiches to paused as soon as the pause button is pressed) and the
remote playback state. Hence avoids side effects when the only the
displayed playback state changes.

Also prevents pause being sent to Chromecast too early.

BUG=593669
==========

to

==========
Distingush between displayed and remote playback state.

Fixes two of the problems causing bug 593669.

distinguishes between the displayed playback state (which, for example
swiches to paused as soon as the pause button is pressed) and the
remote playback state. Hence avoids side effects when the only the
displayed playback state changes.

Also prevents pause being sent to Chromecast too early.

BUG=593669

Committed: https://crrev.com/829655949350c19eea8231f2e2da34679bc42d21
Cr-Commit-Position: refs/heads/master@{#383082}
==========

[commit-bot: I haz the power, 2016-03-24 17:09:41]

Patchset 3 (id:??) landed as
https://crrev.com/829655949350c19eea8231f2e2da34679bc42d21
Cr-Commit-Position: refs/heads/master@{#383082}