chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerController.java - Issue 1839013002: Distingush between displayed and remote playback state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerController.java

Issue 1839013002: Distingush between displayed and remote playback state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerController.java b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerController.java

index 8ad4cc6b342b6560b2834662d6defc0448fad5eb..8d780364704f256b62af74e6d5a05eceb2ce7260 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerController.java

@@ -183,9 +183,7 @@ public class RemoteMediaPlayerController implements MediaRouteController.UiListe

}

onStateReset(controller);

- if (controller.shouldResetState(player)) {

- showMediaRouteDialog(player, controller, currentActivity);

- }

+ showMediaRouteDialog(player, controller, currentActivity);

}

@@ -291,7 +289,7 @@ public class RemoteMediaPlayerController implements MediaRouteController.UiListe

}

@Override

- public void onPlaybackStateChanged(PlayerState oldState, PlayerState newState) {

+ public void onPlaybackStateChanged(PlayerState newState) {

if (newState == PlayerState.PLAYING || newState == PlayerState.LOADING

|| newState == PlayerState.PAUSED) {

CastNotificationControl notificationControl = getNotificationControl();