Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1838733002: Allow LoadNavigationErrorPage to run scripts (Closed)

Created:
4 years, 9 months ago by robwu
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Allow LoadNavigationErrorPage to run scripts Move the LoadNavigationErrorPage call from DidFinishDocumentLoad to RunScriptsAtDocumentReady, because the former is in a ScriptForbiddenScope and caused an assertion to be triggered in blink::beforeCallEnteredCallback when the beforeunload listeners were ran as a part of the navigation. BUG=590634 Review URL: https://codereview.chromium.org/1837483002 Cr-Commit-Position: refs/heads/master@{#383355} (cherry picked from commit 2718dfcda8f7afd32b5229d91c3314bf61faf16c) Committed: https://chromium.googlesource.com/chromium/src/+/74769ef66878333073c4a50624ecf1edd7e07750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -42 lines) Patch
M components/test_runner/web_frame_test_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +23 lines, -17 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
robwu
4 years, 9 months ago (2016-03-26 23:40:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
74769ef66878333073c4a50624ecf1edd7e07750.

Powered by Google App Engine
This is Rietveld 408576698