Allow LoadNavigationErrorPage to run scripts

Allow LoadNavigationErrorPage to run scripts

Move the LoadNavigationErrorPage call from DidFinishDocumentLoad to
RunScriptsAtDocumentReady, because the former is in a
ScriptForbiddenScope and caused an assertion to be triggered in
blink::beforeCallEnteredCallback when the beforeunload listeners were
ran as a part of the navigation.

BUG=590634
Committed: https://crrev.com/2718dfcda8f7afd32b5229d91c3314bf61faf16c
Cr-Commit-Position: refs/heads/master@{#383355}

[robwu, 2016-03-25 13:55:19]

rob@robwu.nl changed reviewers:
+ esprehn@chromium.org

[robwu, 2016-03-25 13:55:20]

It turns out that the ScriptForbiddenScope added in
https://codereview.chromium.org/1642283002/ was too strict, so I've moved the
error page navigation logic from DidFinishDocumentLoad to
RunScriptsAtDocumentReady

The stack trace that motivated this patch is here: https://crbug.com/590634#c41

[esprehn, 2016-03-25 20:14:05]

lgtm

[robwu, 2016-03-25 20:41:06]

rob@robwu.nl changed reviewers:
+ rbyers@chromium.org

[robwu, 2016-03-25 20:41:06]

Rick, could you rs lg components/test_runner/web_frame_test_proxy.h ?

[Rick Byers, 2016-03-25 20:46:41]

Yep, components/test_runner RS LGTM

[robwu, 2016-03-25 20:52:24]

The CQ bit was checked by rob@robwu.nl

[commit-bot: I haz the power, 2016-03-25 20:52:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837483002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837483002/1

[commit-bot: I haz the power, 2016-03-25 20:58:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-25 21:00:21]

Description was changed from

==========
Allow LoadNavigationErrorPage to run scripts

Move the LoadNavigationErrorPage call from DidFinishDocumentLoad to
RunScriptsAtDocumentReady, because the former is in a
ScriptForbiddenScope and caused an assertion to be triggered in
blink::beforeCallEnteredCallback when the beforeunload listeners were
ran as a part of the navigation.

BUG=590634
==========

to

==========
Allow LoadNavigationErrorPage to run scripts

Move the LoadNavigationErrorPage call from DidFinishDocumentLoad to
RunScriptsAtDocumentReady, because the former is in a
ScriptForbiddenScope and caused an assertion to be triggered in
blink::beforeCallEnteredCallback when the beforeunload listeners were
ran as a part of the navigation.

BUG=590634

Committed: https://crrev.com/2718dfcda8f7afd32b5229d91c3314bf61faf16c
Cr-Commit-Position: refs/heads/master@{#383355}
==========

[commit-bot: I haz the power, 2016-03-25 21:00:24]

Patchset 1 (id:??) landed as
https://crrev.com/2718dfcda8f7afd32b5229d91c3314bf61faf16c
Cr-Commit-Position: refs/heads/master@{#383355}