third_party/WebKit/Source/web/FrameLoaderClientImpl.h - Issue 1838733002: Allow LoadNavigationErrorPage to run scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.h

Issue 1838733002: Allow LoadNavigationErrorPage to run scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.h

diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.h b/third_party/WebKit/Source/web/FrameLoaderClientImpl.h

index 5231007681892a949ab1b325ddb841f1bf186640..02765bc551e38f1100f77b4b20b32f699942f8d9 100644

--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.h

+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.h

@@ -61,7 +61,7 @@ public:

void dispatchDidClearWindowObjectInMainWorld() override;

void documentElementAvailable() override;

void runScriptsAtDocumentElementAvailable() override;

- void runScriptsAtDocumentReady() override;

+ void runScriptsAtDocumentReady(bool documentIsEmpty) override;

void didCreateScriptContext(v8::Local<v8::Context>, int extensionGroup, int worldId) override;

void willReleaseScriptContext(v8::Local<v8::Context>, int worldId) override;

@@ -97,7 +97,7 @@ public:

void dispatchDidCommitLoad(HistoryItem*, HistoryCommitType) override;

void dispatchDidFailProvisionalLoad(const ResourceError&, HistoryCommitType) override;

void dispatchDidFailLoad(const ResourceError&, HistoryCommitType) override;

- void dispatchDidFinishDocumentLoad(bool documentIsEmpty) override;

+ void dispatchDidFinishDocumentLoad() override;

void dispatchDidFinishLoad() override;

void dispatchDidChangeThemeColor() override;