Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 183853024: Clean up compute_interfaces_info.py (Closed)

Created:
6 years, 9 months ago by Nils Barth (inactive)
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Clean up compute_interfaces_info.py This is the compute_interfaces_info.py side of the post-split cleanup. This finishes the build factoring. (Still need to add more caching for speed and some more use of Jinja for clarity, but mostly done with build.) Two notable changes: * We only need to store *inherited* extended attributes, not all extended  attributes (in auxiliary variable; needed more for event interfaces, gone now).  This simplifies the inheritance resolution, and reduces duplication. * Always include the same keys in the info dict, even if the value is empty.  This simplifies both setting (since no test) and use:  instead of having "if key in dict and dict[key]..."  we can just have "if dict[key]".  It also helps consistency, since we were doing it 2 ways before. BUG=341748 R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -43 lines) Patch
M Source/bindings/scripts/code_generator_v8.py View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/scripts/compute_interfaces_info.py View 4 chunks +27 lines, -38 lines 0 comments Download
M Source/bindings/scripts/generate_event_interfaces.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Nils Barth (inactive)
Last build refactoring CL!
6 years, 9 months ago (2014-03-04 07:43:23 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-04 08:39:27 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-06 08:19:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/183853024/1
6 years, 9 months ago (2014-03-06 08:19:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 08:56:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-06 08:56:02 UTC) #6
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 9 months ago (2014-03-06 08:56:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/183853024/1
6 years, 9 months ago (2014-03-06 08:56:52 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 09:36:59 UTC) #9
Message was sent while issue was closed.
Change committed as 168610

Powered by Google App Engine
This is Rietveld 408576698