Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: Source/bindings/scripts/code_generator_v8.py

Issue 183853024: Clean up compute_interfaces_info.py (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/compute_interfaces_info.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.py
diff --git a/Source/bindings/scripts/code_generator_v8.py b/Source/bindings/scripts/code_generator_v8.py
index 1698085bfd36c9f3c8e96909406ff530059e68bc..efb5f671b7f815cebc6c6c8dd869ab28d607909d 100644
--- a/Source/bindings/scripts/code_generator_v8.py
+++ b/Source/bindings/scripts/code_generator_v8.py
@@ -89,7 +89,7 @@ class CodeGeneratorV8(object):
v8_types.set_ancestors(dict(
(interface_name, interface_info['ancestors'])
for interface_name, interface_info in interfaces_info.iteritems()
- if 'ancestors' in interface_info))
+ if interface_info['ancestors']))
v8_types.set_callback_interfaces(set(
interface_name
for interface_name, interface_info in interfaces_info.iteritems()
@@ -97,12 +97,11 @@ class CodeGeneratorV8(object):
v8_types.set_implemented_as_interfaces(dict(
(interface_name, interface_info['implemented_as'])
for interface_name, interface_info in interfaces_info.iteritems()
- if 'implemented_as' in interface_info))
+ if interface_info['implemented_as']))
v8_types.set_will_be_garbage_collected_types(set(
interface_name
for interface_name, interface_info in interfaces_info.iteritems()
- if 'inherited_extended_attributes' in interface_info and
- 'WillBeGarbageCollected' in interface_info['inherited_extended_attributes']))
+ if 'WillBeGarbageCollected' in interface_info['inherited_extended_attributes']))
def generate_code(self, definitions, interface_name):
"""Returns .h/.cpp code as (header_text, cpp_text)."""
« no previous file with comments | « no previous file | Source/bindings/scripts/compute_interfaces_info.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698