Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1838373002: Remove unnecessary isolate argument from some visitors (Closed)

Created:
4 years, 8 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org, siva
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unnecessary isolate argument from some visitors BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/40d8eee81e71fd9e386566d8298124ffde08c27e

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -56 lines) Patch
M runtime/vm/compiler_stats.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/disassembler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/heap_test.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object_graph.cc View 1 5 chunks +6 lines, -8 lines 0 comments Download
M runtime/vm/object_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/pages.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/profiler.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/scavenger_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/service.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/snapshot.cc View 2 chunks +1 line, -3 lines 0 comments Download
M runtime/vm/symbols.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/verifier.h View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/verifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/visitor.h View 1 4 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 8 months ago (2016-03-29 21:06:57 UTC) #2
regis
LGTM
4 years, 8 months ago (2016-03-29 21:17:17 UTC) #3
srdjan
4 years, 8 months ago (2016-03-29 21:48:07 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
40d8eee81e71fd9e386566d8298124ffde08c27e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698