runtime/vm/disassembler.cc - Issue 1838373002: Remove unnecessary isolate argument from some visitors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler.cc

Issue 1838373002: Remove unnecessary isolate argument from some visitors (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Cleanup Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/disassembler.cc

diff --git a/runtime/vm/disassembler.cc b/runtime/vm/disassembler.cc

index 5ba92d94041b1d4ef50ceadd40e324f89d0b486c..9f3d4a3a62725c667e7cb54635108c6d7fb35689 100644

--- a/runtime/vm/disassembler.cc

+++ b/runtime/vm/disassembler.cc

@@ -99,8 +99,7 @@ void DisassembleToJSONStream::Print(const char* format, ...) {

class FindAddrVisitor : public FindObjectVisitor {

public:

- explicit FindAddrVisitor(uword addr)

- : FindObjectVisitor(Isolate::Current()), addr_(addr) { }

+ explicit FindAddrVisitor(uword addr) : addr_(addr) { }

virtual ~FindAddrVisitor() { }

virtual uword filter_addr() const { return addr_; }

« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/heap_test.cc » ('j') | no next file with comments »