runtime/vm/pages.cc - Issue 1838373002: Remove unnecessary isolate argument from some visitors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/pages.cc

Issue 1838373002: Remove unnecessary isolate argument from some visitors (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Cleanup Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/pages.cc

diff --git a/runtime/vm/pages.cc b/runtime/vm/pages.cc

index 177b09159a0bcbe8839fffa65ec068345d7a0fd9..4b46452761a1e2530df4a880ef31e05a9d46d0e8 100644

--- a/runtime/vm/pages.cc

+++ b/runtime/vm/pages.cc

@@ -698,8 +698,7 @@ void PageSpace::PrintToJSONObject(JSONObject* object) const {

class HeapMapAsJSONVisitor : public ObjectVisitor {

public:

- explicit HeapMapAsJSONVisitor(JSONArray* array)

- : ObjectVisitor(NULL), array_(array) {}

+ explicit HeapMapAsJSONVisitor(JSONArray* array) : array_(array) { }

virtual void VisitObject(RawObject* obj) {

array_->AddValue(obj->Size() / kObjectAlignment);

array_->AddValue(obj->GetClassId());

« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/profiler.cc » ('j') | no next file with comments »