Make missing or misspelled DLLs a build-time failure

Make missing or misspelled DLLs a build-time failure

While fixing gn component mini_installer I omitted a comma in a list of
file names. The bogus file name this created was not noticed at build
time. This change requires that every file name or pattern in the list
of globs must expand to at least one DLL, thus making a missing comma
a build-time error.

See this URL for the missing comma that almost got commited:
crrev.com/1835993002/diff2/20001:40001/chrome/tools/build/win/create_installer_archive.py

BUG=596885
Committed: https://crrev.com/c9d3ca02c5b8e74ba10d351e5db7c01ed5094dfb
Cr-Commit-Position: refs/heads/master@{#383773}

[brucedawson, 2016-03-28 21:59:12]

brucedawson@chromium.org changed reviewers:
+ robertshield@chromium.org

[brucedawson, 2016-03-28 21:59:12]

Just a little error checking - a build-time test.

[robertshield, 2016-03-29 03:03:29]

Good idea, LGTM w/ optional nit

https://codereview.chromium.org/1837943002/diff/1/chrome/tools/build/win/crea...
File chrome/tools/build/win/create_installer_archive.py (right):

https://codereview.chromium.org/1837943002/diff/1/chrome/tools/build/win/crea...
chrome/tools/build/win/create_installer_archive.py:523: raise Exception('No
matching DLL found for "%s" pattern.' %
optional nit: this is likely to show up for a dev building mini_installer after
the dependencies are altered. An easier to grok error message might be

"Missing expected DLL for component build mini_installer: %s"

[brucedawson, 2016-03-29 17:32:12]

On 2016/03/29 03:03:29, robertshield wrote:
> Good idea, LGTM w/ optional nit
> 
>
https://codereview.chromium.org/1837943002/diff/1/chrome/tools/build/win/crea...
> File chrome/tools/build/win/create_installer_archive.py (right):
> 
>
https://codereview.chromium.org/1837943002/diff/1/chrome/tools/build/win/crea...
> chrome/tools/build/win/create_installer_archive.py:523: raise Exception('No
> matching DLL found for "%s" pattern.' %
> optional nit: this is likely to show up for a dev building mini_installer
after
> the dependencies are altered. An easier to grok error message might be
> 
> "Missing expected DLL for component build mini_installer: %s"

Updated the message to roughly that, and retested. Committing now.

[brucedawson, 2016-03-29 17:32:16]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2016-03-29 17:32:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertshield@chromium.org
Link to the patchset: https://codereview.chromium.org/1837943002/#ps20001
(title: "Changing message based on CL feedback")

[commit-bot: I haz the power, 2016-03-29 17:32:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837943002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837943002/20001

[commit-bot: I haz the power, 2016-03-29 18:17:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-29 18:19:58]

Description was changed from

==========
Make missing or misspelled DLLs a build-time failure

While fixing gn component mini_installer I omitted a comma in a list of
file names. The bogus file name this created was not noticed at build
time. This change requires that every file name or pattern in the list
of globs must expand to at least one DLL, thus making a missing comma
a build-time error.

See this URL for the missing comma that almost got commited:
crrev.com/1835993002/diff2/20001:40001/chrome/tools/build/win/create_installer_archive.py

BUG=596885
==========

to

==========
Make missing or misspelled DLLs a build-time failure

While fixing gn component mini_installer I omitted a comma in a list of
file names. The bogus file name this created was not noticed at build
time. This change requires that every file name or pattern in the list
of globs must expand to at least one DLL, thus making a missing comma
a build-time error.

See this URL for the missing comma that almost got commited:
crrev.com/1835993002/diff2/20001:40001/chrome/tools/build/win/create_installer_archive.py

BUG=596885

Committed: https://crrev.com/c9d3ca02c5b8e74ba10d351e5db7c01ed5094dfb
Cr-Commit-Position: refs/heads/master@{#383773}
==========

[commit-bot: I haz the power, 2016-03-29 18:19:59]

Patchset 2 (id:??) landed as
https://crrev.com/c9d3ca02c5b8e74ba10d351e5db7c01ed5094dfb
Cr-Commit-Position: refs/heads/master@{#383773}