Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/tools/build/win/create_installer_archive.py

Issue 1837943002: Make missing or misspelled DLLs a build-time failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changing message based on CL feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Script to create Chrome Installer archive. 6 """Script to create Chrome Installer archive.
7 7
8 This script is used to create an archive of all the files required for a 8 This script is used to create an archive of all the files required for a
9 Chrome install in appropriate directory structure. It reads chrome.release 9 Chrome install in appropriate directory structure. It reads chrome.release
10 file as input, creates chrome.7z archive, compresses setup.exe and 10 file as input, creates chrome.7z archive, compresses setup.exe and
(...skipping 501 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 # DLLs needed due to source sets. 512 # DLLs needed due to source sets.
513 'base_i18n.dll', 513 'base_i18n.dll',
514 'ipc.dll', 514 'ipc.dll',
515 'net.dll', 515 'net.dll',
516 'prefs.dll', 516 'prefs.dll',
517 'protobuf_lite.dll', 517 'protobuf_lite.dll',
518 'url_lib.dll' ] 518 'url_lib.dll' ]
519 for setup_component_dll_glob in setup_component_dll_globs: 519 for setup_component_dll_glob in setup_component_dll_globs:
520 setup_component_dlls = glob.glob(os.path.join(build_dir, 520 setup_component_dlls = glob.glob(os.path.join(build_dir,
521 setup_component_dll_glob)) 521 setup_component_dll_glob))
522 if len(setup_component_dlls) == 0:
523 raise Exception('Error: missing expected DLL for component build '
524 'mini_installer: "%s"' % setup_component_dll_glob)
522 for setup_component_dll in setup_component_dlls: 525 for setup_component_dll in setup_component_dlls:
523 g_archive_inputs.append(setup_component_dll) 526 g_archive_inputs.append(setup_component_dll)
524 shutil.copy(setup_component_dll, installer_dir) 527 shutil.copy(setup_component_dll, installer_dir)
525 528
526 # Stage all the component DLLs found in |build_dir| to the |version_dir| (for 529 # Stage all the component DLLs found in |build_dir| to the |version_dir| (for
527 # the version assembly to be able to refer to them below and make sure 530 # the version assembly to be able to refer to them below and make sure
528 # chrome.exe can find them at runtime). The component DLLs are considered to 531 # chrome.exe can find them at runtime). The component DLLs are considered to
529 # be all the DLLs which have not already been added to the |version_dir| by 532 # be all the DLLs which have not already been added to the |version_dir| by
530 # virtue of chrome.release. 533 # virtue of chrome.release.
531 build_dlls = glob.glob(os.path.join(build_dir, '*.dll')) 534 build_dlls = glob.glob(os.path.join(build_dir, '*.dll'))
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 MINI_INSTALLER_INPUT_FILE) 681 MINI_INSTALLER_INPUT_FILE)
679 682
680 return options 683 return options
681 684
682 685
683 if '__main__' == __name__: 686 if '__main__' == __name__:
684 options = _ParseOptions() 687 options = _ParseOptions()
685 if options.verbose: 688 if options.verbose:
686 print sys.argv 689 print sys.argv
687 sys.exit(main(options)) 690 sys.exit(main(options))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698