chrome/tools/build/win/create_installer_archive.py - Issue 1837943002: Make missing or misspelled DLLs a build-time failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/build/win/create_installer_archive.py

Issue 1837943002: Make missing or misspelled DLLs a build-time failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changing message based on CL feedback Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/tools/build/win/create_installer_archive.py

diff --git a/chrome/tools/build/win/create_installer_archive.py b/chrome/tools/build/win/create_installer_archive.py

index 313af85660b0d4fc6c8a33fadaa5c164c9e3efa2..aed37856d5b2427bc132b3df8609e016d621b56c 100755

--- a/chrome/tools/build/win/create_installer_archive.py

+++ b/chrome/tools/build/win/create_installer_archive.py

@@ -519,6 +519,9 @@ def DoComponentBuildTasks(staging_dir, build_dir, target_arch, current_version):

for setup_component_dll_glob in setup_component_dll_globs:

setup_component_dlls = glob.glob(os.path.join(build_dir,

setup_component_dll_glob))

+ if len(setup_component_dlls) == 0:

+ raise Exception('Error: missing expected DLL for component build '

+ 'mini_installer: "%s"' % setup_component_dll_glob)

for setup_component_dll in setup_component_dlls:

g_archive_inputs.append(setup_component_dll)

shutil.copy(setup_component_dll, installer_dir)

« no previous file with comments | « no previous file | no next file » | no next file with comments »