Migrate extensions/* to net::IPAddress.

Migrate extensions/* to net::IPAddress.

BUG=496258
Committed: https://crrev.com/6db27d389b372c9c8d21764f37f277eeddb9a789
Cr-Commit-Position: refs/heads/master@{#383929}

[martijnc, 2016-03-28 18:31:02]

Patchset #1 (id:1) has been deleted

[martijnc, 2016-03-28 18:51:27]

martijn@martijnc.be changed reviewers:
+ rockot@chromium.org, wez@chromium.org

[martijnc, 2016-03-29 18:00:04]

+rockot for extensions/browser/api/socket/socket.cc
+wez for extensions/browser/api/cast_channel/*

Can you take a look?

Thanks!

[Ken Rockot(use gerrit already), 2016-03-29 18:08:12]

lgtm

[eroman, 2016-03-29 18:10:51]

eroman@chromium.org changed reviewers:
+ eroman@chromium.org

[eroman, 2016-03-29 18:10:51]

drive-by LGTM

https://codereview.chromium.org/1837713002/diff/20001/extensions/browser/api/...
File extensions/browser/api/cast_channel/logger.cc (right):

https://codereview.chromium.org/1837713002/diff/20001/extensions/browser/api/...
extensions/browser/api/cast_channel/logger.cc:148:
aggregated_socket_event.set_endpoint_id(ip.bytes().back());
As far as refactoring goes, this is a correct.

But not familiar with this code to know if the pre-existing code is right -- the
assumption is that |ip| is non-empty. Seems plausible that is correct though :)

[Wez, 2016-03-29 20:46:29]

LGTM w/ nit

https://codereview.chromium.org/1837713002/diff/20001/extensions/browser/api/...
File extensions/browser/api/cast_channel/logger.cc (right):

https://codereview.chromium.org/1837713002/diff/20001/extensions/browser/api/...
extensions/browser/api/cast_channel/logger.cc:148:
aggregated_socket_event.set_endpoint_id(ip.bytes().back());
On 2016/03/29 18:10:51, eroman wrote:
> As far as refactoring goes, this is a correct.
> 
> But not familiar with this code to know if the pre-existing code is right --
the
> assumption is that |ip| is non-empty. Seems plausible that is correct though
:)

Fair point; |cast_socket.ip_endpoint()| is the address supplied to the
CastChannel::Open() API, so by the time we reach here we can assume it's valid -
I'd prefer a DCHECK here to document that, ideally.

[martijnc, 2016-03-29 21:00:48]

Thank you.

https://codereview.chromium.org/1837713002/diff/20001/extensions/browser/api/...
File extensions/browser/api/cast_channel/logger.cc (right):

https://codereview.chromium.org/1837713002/diff/20001/extensions/browser/api/...
extensions/browser/api/cast_channel/logger.cc:148:
aggregated_socket_event.set_endpoint_id(ip.bytes().back());
On 2016/03/29 at 20:46:29, Wez wrote:
> On 2016/03/29 18:10:51, eroman wrote:
> > As far as refactoring goes, this is a correct.
> > 
> > But not familiar with this code to know if the pre-existing code is right --
the
> > assumption is that |ip| is non-empty. Seems plausible that is correct though
:)
> 
> Fair point; |cast_socket.ip_endpoint()| is the address supplied to the
CastChannel::Open() API, so by the time we reach here we can assume it's valid -
I'd prefer a DCHECK here to document that, ideally.

Added.

[martijnc, 2016-03-30 07:29:07]

The CQ bit was checked by martijn@martijnc.be

[martijnc, 2016-03-30 07:29:07]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
eroman@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/1837713002/#ps40001
(title: "added a DCHECK")

[commit-bot: I haz the power, 2016-03-30 07:29:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1837713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1837713002/40001

[commit-bot: I haz the power, 2016-03-30 08:12:49]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-30 08:14:35]

Description was changed from

==========
Migrate extensions/* to net::IPAddress.

BUG=496258
==========

to

==========
Migrate extensions/* to net::IPAddress.

BUG=496258

Committed: https://crrev.com/6db27d389b372c9c8d21764f37f277eeddb9a789
Cr-Commit-Position: refs/heads/master@{#383929}
==========

[commit-bot: I haz the power, 2016-03-30 08:14:36]

Patchset 2 (id:??) landed as
https://crrev.com/6db27d389b372c9c8d21764f37f277eeddb9a789
Cr-Commit-Position: refs/heads/master@{#383929}