extensions/browser/api/cast_channel/logger.cc - Issue 1837713002: Migrate extensions/* to net::IPAddress.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/logger.cc

Issue 1837713002: Migrate extensions/* to net::IPAddress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added a DCHECK Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/cast_channel/logger.cc

diff --git a/extensions/browser/api/cast_channel/logger.cc b/extensions/browser/api/cast_channel/logger.cc

index ba187da8772721b1c3e6cb972e503066d842ade9..1ea0e24f10c90a2ddeb29a9c17ae36489024bb1c 100644

--- a/extensions/browser/api/cast_channel/logger.cc

+++ b/extensions/browser/api/cast_channel/logger.cc

@@ -144,8 +144,9 @@ void Logger::LogNewSocketEvent(const CastSocket& cast_socket) {

AggregatedSocketEvent& aggregated_socket_event =

LogSocketEvent(cast_socket.id(), event);

- const net::IPAddressNumber& ip = cast_socket.ip_endpoint().address().bytes();

- aggregated_socket_event.set_endpoint_id(ip.back());

+ const net::IPAddress& ip = cast_socket.ip_endpoint().address();

+ DCHECK(ip.IsValid());

+ aggregated_socket_event.set_endpoint_id(ip.bytes().back());

aggregated_socket_event.set_channel_auth_type(cast_socket.channel_auth() ==

CHANNEL_AUTH_TYPE_SSL

? proto::SSL