Migrate extensions/* to net::IPAddress.

extensions/browser/api/cast_channel/logger.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/cast_channel/logger.h"
 
 #include <stdint.h>
 
 #include <string>
 #include <utility>
@@ skipping 126 matching lines @@
 Logger::~Logger() {
 }
 
 void Logger::LogNewSocketEvent(const CastSocket& cast_socket) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   SocketEvent event = CreateEvent(proto::CAST_SOCKET_CREATED);
   AggregatedSocketEvent& aggregated_socket_event =
       LogSocketEvent(cast_socket.id(), event);
 
-  const net::IPAddressNumber& ip = cast_socket.ip_endpoint().address().bytes();
-  aggregated_socket_event.set_endpoint_id(ip.back());
+  const net::IPAddress& ip = cast_socket.ip_endpoint().address();
+  aggregated_socket_event.set_endpoint_id(ip.bytes().back());

[eroman, 2016/03/29 18:10:51]

As far as refactoring goes, this is a correct.

But not familiar with this code to know if the pre-existing code is right -- the
assumption is that |ip| is non-empty. Seems plausible that is correct though :)

[Wez, 2016/03/29 20:46:29]

Fair point; |cast_socket.ip_endpoint()| is the address supplied to the
CastChannel::Open() API, so by the time we reach here we can assume it's valid -
I'd prefer a DCHECK here to document that, ideally.

[martijnc, 2016/03/29 21:00:48]

Added.

   aggregated_socket_event.set_channel_auth_type(cast_socket.channel_auth() ==
                                                         CHANNEL_AUTH_TYPE_SSL
                                                     ? proto::SSL
                                                     : proto::SSL_VERIFIED);
 }
 
 void Logger::LogSocketEvent(int channel_id, EventType event_type) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   LogSocketEventWithDetails(channel_id, event_type, std::string());
@@ skipping 198 matching lines @@
   if (it != aggregated_socket_events_.end()) {
     return it->second->last_errors;
   } else {
     return LastErrors();
   }
 }
 
 }  // namespace cast_channel
 }  // namespace api
 }  // namespace extensions