Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 1836843002: Replace notImplemented() in core/html/parser/ with DVLOG(1). (Closed)

Created:
4 years, 8 months ago by tkent
Modified:
4 years, 8 months ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace notImplemented() in core/html/parser/ with DVLOG(1). This is a part of the task removing notImplemented(). We can't replace notImplemented()s in core/html/parser/ with NOTIMPLEMENTED() because they hit too frequently. These logs are not visible by default even in Debug build. They are visible by --vmodule flag. e.g. % run-webkit-tests --debug --additional-driver-flag=--vmodule=HTMLTreeBuilder=1 BUG=596760, 597781 Committed: https://crrev.com/62d2d8f07c321e78398a12e1344773f8db169f13 Cr-Commit-Position: refs/heads/master@{#383605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
kouhei@, would you review this please?
4 years, 8 months ago (2016-03-28 06:06:07 UTC) #4
kouhei (in TOK)
lgtm compile failure looks irrelevant.
4 years, 8 months ago (2016-03-28 10:51:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1836843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1836843002/1
4 years, 8 months ago (2016-03-28 23:23:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 23:28:37 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 23:29:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62d2d8f07c321e78398a12e1344773f8db169f13
Cr-Commit-Position: refs/heads/master@{#383605}

Powered by Google App Engine
This is Rietveld 408576698