third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp - Issue 1836843002: Replace notImplemented() in core/html/parser/ with DVLOG(1).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

Issue 1836843002: Replace notImplemented() in core/html/parser/ with DVLOG(1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp ('k') | third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp b/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

index 486d24313aa2729e2c26b01df22ababfdc867395..40a3dce284d1e8c269a064de95c20ff3c2905609 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

@@ -383,7 +383,7 @@ bool HTMLScriptRunner::requestPendingScript(PendingScript* pendingScript, Elemen

// This should correctly return 0 for empty or invalid srcValues.

ScriptResource* resource = toScriptLoaderIfPossible(script)->resource();

if (!resource) {

- notImplemented(); // Dispatch error event.

+ DVLOG(1) << "Not implemented."; // Dispatch error event.

return false;

}

pendingScript->setScriptResource(resource);