third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp - Issue 1836843002: Replace notImplemented() in core/html/parser/ with DVLOG(1).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

Issue 1836843002: Replace notImplemented() in core/html/parser/ with DVLOG(1). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp b/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

index 8bb14431a033837cc28b574189fcfdcefafe0277..1638b760424e25fd55474df7ff81e064cd59b23a 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp

@@ -665,7 +665,7 @@ void HTMLConstructionSite::insertScriptElement(AtomicHTMLToken* token)

void HTMLConstructionSite::insertForeignElement(AtomicHTMLToken* token, const AtomicString& namespaceURI)

{

ASSERT(token->type() == HTMLToken::StartTag);

- notImplemented(); // parseError when xmlns or xmlns:xlink are wrong.

+ DVLOG(1) << "Not implemented."; // parseError when xmlns or xmlns:xlink are wrong.

RefPtrWillBeRawPtr<Element> element = createElement(token, namespaceURI);

if (scriptingContentIsAllowed(m_parserContentPolicy) || !toScriptLoaderIfPossible(element.get()))

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp » ('j') | no next file with comments »