third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html - Issue 1836203002: Change the battery-status layout tests to use JS mocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html

Issue 1836203002: Change the battery-status layout tests to use JS mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js ('K') | « third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js ('k') | third_party/WebKit/LayoutTests/resources/mojo-helpers.js » ('j') | third_party/WebKit/Source/modules/battery/testing/InternalsBattery.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html

diff --git a/third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html b/third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html

index 8561b46732184abcfa767798b0baefe0f13f12a4..3f576618072d4275b05685aa0857a1216d523275 100644

--- a/third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html

+++ b/third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html

@@ -2,6 +2,8 @@

<html>

<body>

+<script src="../resources/mojo-helpers.js"></script>

+<script src="resources/mock-battery-monitor.js"></script>

description("Test to ensure level is reported with restricted precision.");

@@ -18,10 +20,6 @@ testRunner.waitUntilDone();

var levelFullPrecision = 0.556789;

var levelRounded = 0.56;

-function setAndFireMockBatteryInfo(charging, chargingTime, dischargingTime, level) {

- window.internals.updateBatteryStatus(charging, chargingTime, dischargingTime, level);

var battery;

Yuki 2016/03/30 02:39:46 We don't need this variable. Let's add |let| on l

function batteryStatusSuccess(batteryManager) {

debug('batteryStatusSuccess invoked');

@@ -30,13 +28,10 @@ function batteryStatusSuccess(batteryManager) {

setTimeout(finishJSTest, 0);

}

-function batteryStatusFailure() {

- testFailed('failed to successfully resolve the promise');

- setTimeout(finishJSTest, 0);

-navigator.getBattery().then(batteryStatusSuccess, batteryStatusFailure);

-setAndFireMockBatteryInfo(false, 10, 20, levelFullPrecision);

+ready.then(() => {

+ navigator.getBattery().then(batteryStatusSuccess, batteryStatusFailure);

+ setAndFireMockBatteryInfo(false, 10, 20, levelFullPrecision);

+});

</script>

</body>

</html>