Remove secondary player from Media Sessions

Remove secondary player from Media Sessions

When we switch Android media players, for cast, we no longer want audio
focus changes associated with old player to take effect. To handle this
remove the old player from the Media Sessions.

The new player is responsible for adding itself to the Media Sessions if
it needs to. The remote player doesn't need to, and, after stopping casting
the local player will do so when the user presses play.

BUG=595373
Review URL: https://codereview.chromium.org/1823983002

Cr-Commit-Position: refs/heads/master@{#382613}
(cherry picked from commit 4bee90cc8b21594a3fc5c4055887886aa2009865)

Committed: https://chromium.googlesource.com/chromium/src/+/3ad63a558b2fbe889d02eeffe2f664955bfc9f07

[aberent, 2016-03-29 09:39:32]

Description was changed from

==========
Remove secondary player from Media Sessions

When we switch Android media players, for cast, we no longer want audio
focus changes associated with old player to take effect. To handle this
remove the old player from the Media Sessions.

The new player is responsible for adding itself to the Media Sessions if
it needs to. The remote player doesn't need to, and, after stopping casting
the local player will do so when the user presses play.

BUG=595373

Review URL: https://codereview.chromium.org/1823983002

Cr-Commit-Position: refs/heads/master@{#382613}
(cherry picked from commit 4bee90cc8b21594a3fc5c4055887886aa2009865)
==========

to

==========
Remove secondary player from Media Sessions

When we switch Android media players, for cast, we no longer want audio
focus changes associated with old player to take effect. To handle this
remove the old player from the Media Sessions.

The new player is responsible for adding itself to the Media Sessions if
it needs to. The remote player doesn't need to, and, after stopping casting
the local player will do so when the user presses play.

BUG=595373

Review URL: https://codereview.chromium.org/1823983002

Cr-Commit-Position: refs/heads/master@{#382613}
(cherry picked from commit 4bee90cc8b21594a3fc5c4055887886aa2009865)

Committed:
https://chromium.googlesource.com/chromium/src/+/3ad63a558b2fbe889d02eeffe2f6...
==========

[aberent, 2016-03-29 09:39:35]

Committed patchset #1 (id:1) manually as
3ad63a558b2fbe889d02eeffe2f664955bfc9f07.

[boliu, 2016-03-29 17:33:57]

boliu@chromium.org changed reviewers:
+ boliu@chromium.org

[boliu, 2016-03-29 17:33:57]

https://codereview.chromium.org/1836093003/diff/1/content/browser/media/andro...
File content/browser/media/android/media_web_contents_observer_android.cc
(right):

https://codereview.chromium.org/1836093003/diff/1/content/browser/media/andro...
content/browser/media/android/media_web_contents_observer_android.cc:106:
session_controllers_manager()->OnEnd(
This doesn't build on m50 branch. session_controllers_manager() was addedin
https://codereview.chromium.org/1698933004/, which is not in the m50 branch.

There seem to be another merge on top of it, so just reverting isn't great
either. Is there an easy fix?

[aberent, 2016-03-29 17:45:54]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1842763003/ by aberent@chromium.org.

The reason for reverting is: Didn't build on M50..