content/browser/media/android/browser_media_player_manager.cc - Issue 1836093003: Remove secondary player from Media Sessions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/android/browser_media_player_manager.cc

Issue 1836093003: Remove secondary player from Media Sessions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/media/android/browser_media_player_manager.cc

diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc

index a42c31c2b9db45c05ba162fcb2b5efebb75a8783..8d871cb9b31537c4f632fd9bd391598894de8878 100644

--- a/content/browser/media/android/browser_media_player_manager.cc

+++ b/content/browser/media/android/browser_media_player_manager.cc

@@ -652,6 +652,9 @@ scoped_ptr<media::MediaPlayerAndroid> BrowserMediaPlayerManager::SwapPlayer(

#if defined(VIDEO_HOLE)

ReleaseExternalSurface(player_id);

#endif

+ MediaWebContentsObserverAndroid::FromWebContents(web_contents_)

+ ->DisconnectMediaSession(render_frame_host_,

+ player_id_to_delegate_id_map_[player_id]);

players_.weak_erase(it);

players_.push_back(player);

break;