Remove secondary player from Media Sessions

Remove secondary player from Media Sessions

When we switch Android media players, for cast, we no longer want audio
focus changes associated with old player to take effect. To handle this
remove the old player from the Media Sessions.

The new player is responsible for adding itself to the Media Sessions if
it needs to. The remote player doesn't need to, and, after stopping casting
the local player will do so when the user presses play.

BUG=595373
Committed: https://crrev.com/4bee90cc8b21594a3fc5c4055887886aa2009865
Cr-Commit-Position: refs/heads/master@{#382613}

[aberent, 2016-03-22 11:22:21]

aberent@chromium.org changed reviewers:
+ qinmin@chromium.org

[aberent, 2016-03-22 11:23:05]

Description was changed from

==========
Remove secondary player from Media Sessions

When we switch Android media players, for cast, we no longer want audio
focus changes associated with old player to take effect. To handle this
remove the old player from the Media Sessions.

The new player is responsible for adding itself to the Media Sessions if
it needs to. The remote player doesn't need to, and, after stopping cating
the local player will do so when the user presses play.

BUG=595373
==========

to

==========
Remove secondary player from Media Sessions

When we switch Android media players, for cast, we no longer want audio
focus changes associated with old player to take effect. To handle this
remove the old player from the Media Sessions.

The new player is responsible for adding itself to the Media Sessions if
it needs to. The remote player doesn't need to, and, after stopping casting
the local player will do so when the user presses play.

BUG=595373
==========

[whywhat, 2016-03-22 11:55:57]

avayvod@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2016-03-22 11:55:58]

non-owner lgtm

[aberent, 2016-03-22 16:58:38]

The CQ bit was checked by aberent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 16:58:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823983002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823983002/20001

[qinmin, 2016-03-22 18:01:26]

lgtm

[aberent, 2016-03-22 18:05:20]

The CQ bit was unchecked by aberent@chromium.org

[aberent, 2016-03-22 18:05:22]

The CQ bit was checked by aberent@chromium.org

[commit-bot: I haz the power, 2016-03-22 18:05:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823983002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823983002/20001

[commit-bot: I haz the power, 2016-03-22 18:14:43]

Description was changed from

==========
Remove secondary player from Media Sessions

When we switch Android media players, for cast, we no longer want audio
focus changes associated with old player to take effect. To handle this
remove the old player from the Media Sessions.

The new player is responsible for adding itself to the Media Sessions if
it needs to. The remote player doesn't need to, and, after stopping casting
the local player will do so when the user presses play.

BUG=595373
==========

to

==========
Remove secondary player from Media Sessions

When we switch Android media players, for cast, we no longer want audio
focus changes associated with old player to take effect. To handle this
remove the old player from the Media Sessions.

The new player is responsible for adding itself to the Media Sessions if
it needs to. The remote player doesn't need to, and, after stopping casting
the local player will do so when the user presses play.

BUG=595373
==========

[commit-bot: I haz the power, 2016-03-22 18:14:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-22 18:16:20]

Description was changed from

==========
Remove secondary player from Media Sessions

When we switch Android media players, for cast, we no longer want audio
focus changes associated with old player to take effect. To handle this
remove the old player from the Media Sessions.

The new player is responsible for adding itself to the Media Sessions if
it needs to. The remote player doesn't need to, and, after stopping casting
the local player will do so when the user presses play.

BUG=595373
==========

to

==========
Remove secondary player from Media Sessions

When we switch Android media players, for cast, we no longer want audio
focus changes associated with old player to take effect. To handle this
remove the old player from the Media Sessions.

The new player is responsible for adding itself to the Media Sessions if
it needs to. The remote player doesn't need to, and, after stopping casting
the local player will do so when the user presses play.

BUG=595373

Committed: https://crrev.com/4bee90cc8b21594a3fc5c4055887886aa2009865
Cr-Commit-Position: refs/heads/master@{#382613}
==========

[commit-bot: I haz the power, 2016-03-22 18:16:22]

Patchset 2 (id:??) landed as
https://crrev.com/4bee90cc8b21594a3fc5c4055887886aa2009865
Cr-Commit-Position: refs/heads/master@{#382613}

[DaleCurtis, 2016-03-22 18:46:32]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-03-22 18:46:33]

Hmm, I don't think this is the right fix. This may fix media session but it
leaves the power save blockers alive. We should avoid complicating the manager
interface further.

Instead WebMediaPlayerAndroid::OnConnectedToRemoteDevice() should send
PlayerGone() to release power save blockers and the media session.

[DaleCurtis, 2016-03-22 18:52:37]

Notably, I just fixed the same issue for WMPI:
https://codereview.chromium.org/1813373003

[aberent, 2016-03-22 19:43:59]

On 2016/03/22 18:52:37, DaleCurtis wrote:
> Notably, I just fixed the same issue for WMPI:
> https://codereview.chromium.org/1813373003

I don't think this works for Cast, without significant further changes. The
problem is that Cast both claims audio focus and tells the renderer that it is
casting within the same Java browser message handler. We need to make sure that
the local player has stopped listening for audio focus strictly before Cast
claims audio focus, otherwise we will get the original bug back. Since the
browser/renderer interface is asynchronous going though the renderer will mean
that the local player will stop listening for audio focus changes too late.

[DaleCurtis, 2016-03-22 19:46:02]

What about sending it when requesting remote playback?