Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1510)

Issue 1829253002: Replicate to all renderers the accepted languages set by a layout test. (Closed)

Created:
4 years, 9 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@splitting-web-frame-test-client
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replicate to all renderers the accepted languages set by a layout test. Moving |accept_languages_| from WebTestProxyBase into LayoutTestRuntimeFlags helps to 1) replicate the value requested by a test into all renderers 2) prepare WebTestProxyBase to help with extraction of WebViewTestClient class. BUG=587175, 595089 Committed: https://crrev.com/305f1739ea0dc08182da9d81193b859518f31bc7 Cr-Commit-Position: refs/heads/master@{#384089}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Quit early if the value doesn't really change. #

Total comments: 1

Patch Set 4 : Rebasing... #

Patch Set 5 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -15 lines) Patch
M components/test_runner/layout_test_runtime_flags.h View 1 2 3 4 2 chunks +15 lines, -0 lines 0 comments Download
M components/test_runner/layout_test_runtime_flags.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M components/test_runner/test_runner.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/test_runner.cc View 1 2 3 4 1 chunk +10 lines, -1 line 0 comments Download
M components/test_runner/tracked_dictionary.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/tracked_dictionary.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/test_runner/web_test_proxy.h View 2 chunks +0 lines, -4 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 3 chunks +2 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
Łukasz Anforowicz
jochen@, could you please take a look? https://codereview.chromium.org/1829253002/diff/40001/components/test_runner/test_runner.cc File components/test_runner/test_runner.cc (right): https://codereview.chromium.org/1829253002/diff/40001/components/test_runner/test_runner.cc#newcode2662 components/test_runner/test_runner.cc:2662: return; Turns ...
4 years, 9 months ago (2016-03-25 14:37:59 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-03-30 16:24:06 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829253002/60001
4 years, 8 months ago (2016-03-30 18:04:00 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/11101) ios_dbg_simulator_ninja on ...
4 years, 8 months ago (2016-03-30 18:07:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829253002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829253002/80001
4 years, 8 months ago (2016-03-30 20:05:39 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-03-30 20:55:54 UTC) #14
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/305f1739ea0dc08182da9d81193b859518f31bc7 Cr-Commit-Position: refs/heads/master@{#384089}
4 years, 8 months ago (2016-03-30 20:58:08 UTC) #16
Łukasz Anforowicz
4 years, 8 months ago (2016-03-31 14:13:49 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1851483002/ by lukasza@chromium.org.

The reason for reverting is: Prevents clean reverting of an earlier CL
(https://codereview.chromium.org/1821923003/) that caused use after free related
to color chooser..

Powered by Google App Engine
This is Rietveld 408576698