Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1835583002: VM: Use delay slot in two places in MIPS intrinis code. (Closed)

Created:
4 years, 9 months ago by Florian Schneider
Modified:
4 years, 9 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Use delay slot in two places in MIPS intrinis code. Also, remove outdated comments in two other places. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/4c7d74e49a7bc0bec0b5bd0997b4e28e12484ef6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M runtime/vm/intrinsifier_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 9 months ago (2016-03-25 16:10:37 UTC) #2
zra
lgtm
4 years, 9 months ago (2016-03-25 16:21:47 UTC) #3
Florian Schneider
4 years, 9 months ago (2016-03-25 17:10:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c7d74e49a7bc0bec0b5bd0997b4e28e12484ef6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698