Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: runtime/vm/intrinsifier_arm.cc

Issue 1835583002: VM: Use delay slot in two places in MIPS intrinis code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/intrinsifier_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intrinsifier.h" 8 #include "vm/intrinsifier.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
(...skipping 1308 matching lines...) Expand 10 before | Expand all | Expand 10 after
1319 } 1319 }
1320 const Class& double_class = Class::Handle( 1320 const Class& double_class = Class::Handle(
1321 Isolate::Current()->object_store()->double_class()); 1321 Isolate::Current()->object_store()->double_class());
1322 __ TryAllocate(double_class, &fall_through, R0, R1); // Result register. 1322 __ TryAllocate(double_class, &fall_through, R0, R1); // Result register.
1323 __ StoreDToOffset(D0, R0, Double::value_offset() - kHeapObjectTag); 1323 __ StoreDToOffset(D0, R0, Double::value_offset() - kHeapObjectTag);
1324 __ Ret(); 1324 __ Ret();
1325 __ Bind(&is_smi); // Convert R0 to a double. 1325 __ Bind(&is_smi); // Convert R0 to a double.
1326 __ SmiUntag(R0); 1326 __ SmiUntag(R0);
1327 __ vmovsr(S0, R0); 1327 __ vmovsr(S0, R0);
1328 __ vcvtdi(D1, S0); 1328 __ vcvtdi(D1, S0);
1329 __ b(&double_op); // Then do the comparison. 1329 __ b(&double_op);
1330 __ Bind(&fall_through); 1330 __ Bind(&fall_through);
1331 } 1331 }
1332 } 1332 }
1333 1333
1334 1334
1335 void Intrinsifier::Double_add(Assembler* assembler) { 1335 void Intrinsifier::Double_add(Assembler* assembler) {
1336 DoubleArithmeticOperations(assembler, Token::kADD); 1336 DoubleArithmeticOperations(assembler, Token::kADD);
1337 } 1337 }
1338 1338
1339 1339
(...skipping 794 matching lines...) Expand 10 before | Expand all | Expand 10 after
2134 2134
2135 void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) { 2135 void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) {
2136 __ LoadIsolate(R0); 2136 __ LoadIsolate(R0);
2137 __ ldr(R0, Address(R0, Isolate::current_tag_offset())); 2137 __ ldr(R0, Address(R0, Isolate::current_tag_offset()));
2138 __ Ret(); 2138 __ Ret();
2139 } 2139 }
2140 2140
2141 } // namespace dart 2141 } // namespace dart
2142 2142
2143 #endif // defined TARGET_ARCH_ARM 2143 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/intrinsifier_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698