runtime/vm/intrinsifier_arm64.cc - Issue 1835583002: VM: Use delay slot in two places in MIPS intrinis code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_arm64.cc

Issue 1835583002: VM: Use delay slot in two places in MIPS intrinis code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intrinsifier_arm64.cc

diff --git a/runtime/vm/intrinsifier_arm64.cc b/runtime/vm/intrinsifier_arm64.cc

index 14c421e268e8700a72da961624127c7a11032c80..e4e5b1107782e5ce7362dbfa8e132149a97e9e59 100644

--- a/runtime/vm/intrinsifier_arm64.cc

+++ b/runtime/vm/intrinsifier_arm64.cc

@@ -1422,7 +1422,7 @@ static void DoubleArithmeticOperations(Assembler* assembler, Token::Kind kind) {

__ Bind(&is_smi); // Convert R0 to a double.

__ SmiUntag(R0);

__ scvtfdx(V1, R0);

- __ b(&double_op); // Then do the comparison.

+ __ b(&double_op);

__ Bind(&fall_through);

}

« no previous file with comments | « runtime/vm/intrinsifier_arm.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »