Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: runtime/observatory/lib/src/elements/code_view.dart

Issue 1835393002: Improve error message when attempting to evaluate against a VM-internal object (e.g., a Megamorphic… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/code_view.dart
diff --git a/runtime/observatory/lib/src/elements/code_view.dart b/runtime/observatory/lib/src/elements/code_view.dart
index 9234164b50a8693782d8a853cb2fce8d5e64fec6..d8fa1c77223b46a4b0bf38d5c5e5dc4379023178 100644
--- a/runtime/observatory/lib/src/elements/code_view.dart
+++ b/runtime/observatory/lib/src/elements/code_view.dart
@@ -210,7 +210,7 @@ class CodeViewElement extends ObservatoryElement {
if (content is ServiceObject) {
ServiceRefElement element = new Element.tag('any-service-ref');
element.ref = content;
- cell.append(element);
+ cell.children = [element];
} else if (content != null) {
cell.text = content.toString();
}
« no previous file with comments | « no previous file | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698