Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: runtime/vm/service.cc

Issue 1835393002: Improve error message when attempting to evaluate against a VM-internal object (e.g., a Megamorphic… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/code_view.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index d346361653ed37a201a858b059617c7591e9aa90..499964f80262c87df966af803468bafb989758d3 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -2159,8 +2159,7 @@ static bool Evaluate(Thread* thread, JSONStream* js) {
}
js->PrintError(kInvalidParams,
"%s: invalid 'targetId' parameter: "
- "id '%s' does not correspond to a "
- "library, class, or instance", js->method(), target_id);
+ "Cannot evaluate against a VM-internal object", js->method());
return true;
}
« no previous file with comments | « runtime/observatory/lib/src/elements/code_view.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698