Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: runtime/observatory/lib/src/elements/code_view.dart

Issue 1835393002: Improve error message when attempting to evaluate against a VM-internal object (e.g., a Megamorphic… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library code_view_element; 5 library code_view_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:html'; 8 import 'dart:html';
9 import 'observatory_element.dart'; 9 import 'observatory_element.dart';
10 import 'service_ref.dart'; 10 import 'service_ref.dart';
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 203
204 void _fillDisassemblyDOMRow(TableRowElement tr, int rowIndex) { 204 void _fillDisassemblyDOMRow(TableRowElement tr, int rowIndex) {
205 final row = disassemblyTable.rows[rowIndex]; 205 final row = disassemblyTable.rows[rowIndex];
206 final n = row.values.length; 206 final n = row.values.length;
207 for (var i = 0; i < n; i++) { 207 for (var i = 0; i < n; i++) {
208 final cell = tr.children[i]; 208 final cell = tr.children[i];
209 final content = row.values[i]; 209 final content = row.values[i];
210 if (content is ServiceObject) { 210 if (content is ServiceObject) {
211 ServiceRefElement element = new Element.tag('any-service-ref'); 211 ServiceRefElement element = new Element.tag('any-service-ref');
212 element.ref = content; 212 element.ref = content;
213 cell.append(element); 213 cell.children = [element];
214 } else if (content != null) { 214 } else if (content != null) {
215 cell.text = content.toString(); 215 cell.text = content.toString();
216 } 216 }
217 } 217 }
218 } 218 }
219 219
220 void _updateDisassemblyDOMTable() { 220 void _updateDisassemblyDOMTable() {
221 var tableBody = $['disassemblyTableBody']; 221 var tableBody = $['disassemblyTableBody'];
222 assert(tableBody != null); 222 assert(tableBody != null);
223 // Resize DOM table. 223 // Resize DOM table.
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 } 374 }
375 375
376 void mouseOut(Event e, var detail, Node target) { 376 void mouseOut(Event e, var detail, Node target) {
377 var jt = _findJumpTarget(target); 377 var jt = _findJumpTarget(target);
378 if (jt == null) { 378 if (jt == null) {
379 return; 379 return;
380 } 380 }
381 jt.classes.remove('highlight'); 381 jt.classes.remove('highlight');
382 } 382 }
383 } 383 }
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698