Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1835393002: Improve error message when attempting to evaluate against a VM-internal object (e.g., a Megamorphic… (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve error message when attempting to evaluate against a VM-internal object (e.g., a MegamorphicCache's table). Don't accumulate object annotations on the disassembly when refreshing a Code view. BUG=http://dartbug.com/26008 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/00eff0ff6ac9ce4af468c7e77e9572cf9266d57d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M runtime/observatory/lib/src/elements/code_view.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 8 months ago (2016-03-28 20:44:54 UTC) #3
Cutch
lgtm
4 years, 8 months ago (2016-03-28 20:49:47 UTC) #4
rmacnak
4 years, 8 months ago (2016-03-28 21:51:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
00eff0ff6ac9ce4af468c7e77e9572cf9266d57d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698