Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3836)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.cc

Issue 1835063002: DevTools: make app banner debug messages report with different severity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: win fixed Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher.cc
diff --git a/chrome/browser/banners/app_banner_data_fetcher.cc b/chrome/browser/banners/app_banner_data_fetcher.cc
index da594dc93951d0764b937268c704dce6675aae59..a8c8c32fe2056f7a8df634f475ca16527abed7f2 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.cc
+++ b/chrome/browser/banners/app_banner_data_fetcher.cc
@@ -353,9 +353,9 @@ void AppBannerDataFetcher::OnHasServiceWorker(
if (icon_url.is_empty()) {
OutputDeveloperNotShownMessage(
web_contents,
+ kNoIconMatchingRequirements,
base::IntToString(ManifestIconSelector::ConvertIconSizeFromDpToPx(
- minimum_icon_size_in_dp_)) +
- kNoIconMatchingRequirements,
+ minimum_icon_size_in_dp_)),
is_debug_mode_);
Cancel();
} else if (!FetchAppIcon(web_contents, icon_url)) {
« no previous file with comments | « chrome/browser/android/banners/app_banner_manager_android.cc ('k') | chrome/browser/banners/app_banner_debug_log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698