Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 1835063002: DevTools: make app banner debug messages report with different severity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: win fixed Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_data_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index b1915ccdf376b5e535e95443a9fa080b3e61d8f5..697e9991872502b3cc071a32b77df0b51844a7f1 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -71,7 +71,7 @@ bool AppBannerManagerAndroid::HandleNonWebApp(const std::string& platform,
std::string id_from_app_url = ExtractQueryValueForName(url, kIdName);
if (id_from_app_url.size() && id != id_from_app_url) {
- banners::OutputDeveloperDebugMessage(
+ banners::OutputDeveloperNotShownMessage(
web_contents(), banners::kIgnoredIdsDoNotMatch, is_debug_mode);
return false;
}
@@ -103,14 +103,14 @@ bool AppBannerManagerAndroid::CheckPlatformAndId(const std::string& platform,
const std::string& id,
bool is_debug_mode) {
if (platform != kPlayPlatform) {
- banners::OutputDeveloperDebugMessage(
- web_contents(), platform + banners::kIgnoredNotSupportedOnAndroid,
+ banners::OutputDeveloperNotShownMessage(
+ web_contents(), banners::kIgnoredNotSupportedOnAndroid, platform,
is_debug_mode);
return false;
}
if (id.empty()) {
- banners::OutputDeveloperDebugMessage(web_contents(), banners::kIgnoredNoId,
- is_debug_mode);
+ banners::OutputDeveloperNotShownMessage(
+ web_contents(), banners::kIgnoredNoId, is_debug_mode);
return false;
}
return true;
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_data_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698