Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: chrome/browser/banners/app_banner_debug_log.h

Issue 1835063002: DevTools: make app banner debug messages report with different severity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: win fixed Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_debug_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_debug_log.h
diff --git a/chrome/browser/banners/app_banner_debug_log.h b/chrome/browser/banners/app_banner_debug_log.h
index ca742690118d15b3023d38ee135f43f6e8ef5db6..fa9dbe6e9d819bbb70ece85aa432c9b8005fb2a0 100644
--- a/chrome/browser/banners/app_banner_debug_log.h
+++ b/chrome/browser/banners/app_banner_debug_log.h
@@ -14,34 +14,38 @@ class WebContents;
namespace banners {
// Error message strings used to notify developers via the console.
-extern const char kRendererRequestCancel[];
-extern const char kManifestEmpty[];
-extern const char kNoManifest[];
-extern const char kNoIconMatchingRequirements[];
-extern const char kCannotDownloadIcon[];
-extern const char kNoMatchingServiceWorker[];
-extern const char kNoIconAvailable[];
-extern const char kUserNavigatedBeforeBannerShown[];
-extern const char kStartURLNotValid[];
-extern const char kManifestMissingNameOrShortName[];
-extern const char kManifestMissingSuitableIcon[];
-extern const char kNotLoadedInMainFrame[];
-extern const char kNotServedFromSecureOrigin[];
-extern const char kIgnoredNotSupportedOnAndroid[];
-extern const char kIgnoredNoId[];
-extern const char kIgnoredIdsDoNotMatch[];
+
+enum OutputDeveloperMessageCode {
+ kRendererRequestCancel,
+ kManifestEmpty,
+ kNoManifest,
+ kNoIconMatchingRequirements,
+ kCannotDownloadIcon,
+ kNoMatchingServiceWorker,
+ kNoIconAvailable,
+ kUserNavigatedBeforeBannerShown,
+ kStartURLNotValid,
+ kManifestMissingNameOrShortName,
+ kManifestMissingSuitableIcon,
+ kNotLoadedInMainFrame,
+ kNotServedFromSecureOrigin,
+ kIgnoredNotSupportedOnAndroid,
+ kIgnoredNoId,
+ kIgnoredIdsDoNotMatch,
+};
// Logs a message to the main console if a banner could not be shown
// and the engagement checks have been bypassed.
void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
- const std::string& message,
+ OutputDeveloperMessageCode code,
bool is_debug_mode);
-// Logs a debugging message to the main console if the engagement checks have
-// been bypassed.
-void OutputDeveloperDebugMessage(content::WebContents* web_contents,
- const std::string& message,
- bool is_debug_mode);
+// Logs a message to the main console if a banner could not be shown
+// and the engagement checks have been bypassed.
+void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
+ OutputDeveloperMessageCode code,
+ const std::string& param,
+ bool is_debug_mode);
} // namespace banners
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_debug_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698