Add WSI functions to GrVkInterface

Add WSI functions to GrVkInterface

BUG=skia:5043
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1834903003

Committed: https://skia.googlesource.com/skia/+/e50f3e75392d7be8ae89df8f55b1700100c34ad7

[jvanverth1, 2016-03-25 20:22:35]

Description was changed from

==========
Add WSI functions to GrVkInterface

BUG=skia:5043
==========

to

==========
Add WSI functions to GrVkInterface

BUG=skia:5043
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[jvanverth1, 2016-03-25 21:15:53]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[bsalomon, 2016-03-28 13:05:47]

https://codereview.chromium.org/1834903003/diff/80001/include/gpu/vk/GrVkBack...
File include/gpu/vk/GrVkBackendContext.h (right):

https://codereview.chromium.org/1834903003/diff/80001/include/gpu/vk/GrVkBack...
include/gpu/vk/GrVkBackendContext.h:22: kEXT_debug_report_GrVkExtensionFlag    =
0x0001,
Does this mix interface and device extensions? Do we care about separating them?
Same for features.

https://codereview.chromium.org/1834903003/diff/80001/include/gpu/vk/GrVkInte...
File include/gpu/vk/GrVkInterface.h (right):

https://codereview.chromium.org/1834903003/diff/80001/include/gpu/vk/GrVkInte...
include/gpu/vk/GrVkInterface.h:203: #if defined(VK_USE_PLATFORM_WIN32_KHR)
Will these be used in Ganesh proper or just in the OSWindow code? Wondering if
we should create a different interface for WSI that lives with that code.

[jvanverth1, 2016-03-28 13:35:38]

https://codereview.chromium.org/1834903003/diff/80001/include/gpu/vk/GrVkBack...
File include/gpu/vk/GrVkBackendContext.h (right):

https://codereview.chromium.org/1834903003/diff/80001/include/gpu/vk/GrVkBack...
include/gpu/vk/GrVkBackendContext.h:22: kEXT_debug_report_GrVkExtensionFlag    =
0x0001,
On 2016/03/28 13:05:47, bsalomon wrote:
> Does this mix interface and device extensions? Do we care about separating
them?
> Same for features.

The extensions are specified in docs just like OpenGL, with unique names. It's
just that you may need to enable them either on the interface or the device, or
both. So for this I don't think we care. Features are only a property of the
physical device.

https://codereview.chromium.org/1834903003/diff/80001/include/gpu/vk/GrVkInte...
File include/gpu/vk/GrVkInterface.h (right):

https://codereview.chromium.org/1834903003/diff/80001/include/gpu/vk/GrVkInte...
include/gpu/vk/GrVkInterface.h:203: #if defined(VK_USE_PLATFORM_WIN32_KHR)
On 2016/03/28 13:05:47, bsalomon wrote:
> Will these be used in Ganesh proper or just in the OSWindow code? Wondering if
> we should create a different interface for WSI that lives with that code. 

Sure, I could do that when I get the windowing going. I was just trying to avoid
code duplication.

[bsalomon, 2016-03-28 13:38:12]

lgtm

On 2016/03/28 13:35:38, jvanverth1 wrote:
>
https://codereview.chromium.org/1834903003/diff/80001/include/gpu/vk/GrVkBack...
> File include/gpu/vk/GrVkBackendContext.h (right):
> 
>
https://codereview.chromium.org/1834903003/diff/80001/include/gpu/vk/GrVkBack...
> include/gpu/vk/GrVkBackendContext.h:22: kEXT_debug_report_GrVkExtensionFlag   
=
> 0x0001,
> On 2016/03/28 13:05:47, bsalomon wrote:
> > Does this mix interface and device extensions? Do we care about separating
> them?
> > Same for features.
> 
> The extensions are specified in docs just like OpenGL, with unique names. It's
> just that you may need to enable them either on the interface or the device,
or
> both. So for this I don't think we care. Features are only a property of the
> physical device.

Makes sense.

> 
>
https://codereview.chromium.org/1834903003/diff/80001/include/gpu/vk/GrVkInte...
> File include/gpu/vk/GrVkInterface.h (right):
> 
>
https://codereview.chromium.org/1834903003/diff/80001/include/gpu/vk/GrVkInte...
> include/gpu/vk/GrVkInterface.h:203: #if defined(VK_USE_PLATFORM_WIN32_KHR)
> On 2016/03/28 13:05:47, bsalomon wrote:
> > Will these be used in Ganesh proper or just in the OSWindow code? Wondering
if
> > we should create a different interface for WSI that lives with that code. 
> 
> Sure, I could do that when I get the windowing going. I was just trying to
avoid
> code duplication.

Ok, I think the VkInterface should be stuff that we need to run Ganesh, not
stuff just required by our test tools. Presumably clients will do their own
windowing system integration.

[jvanverth1, 2016-03-28 13:52:05]

On 2016/03/28 13:38:12, bsalomon wrote:
> Ok, I think the VkInterface should be stuff that we need to run Ganesh, not
> stuff just required by our test tools. Presumably clients will do their own
> windowing system integration.

Wait, doesn't nanobench get windowing through SkGLContext? That's in src/gpu/gl,
and the platform-specific code is under that. The other thing is that other than
the handful of platform-specific calls, windowing and swapchain setup is the
same on all platforms. Or do you just want to keep it out of the public header?

[jvanverth1, 2016-03-28 13:52:26]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2016-03-28 13:52:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1834903003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1834903003/80001

[commit-bot: I haz the power, 2016-03-28 14:03:10]

Description was changed from

==========
Add WSI functions to GrVkInterface

BUG=skia:5043
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add WSI functions to GrVkInterface

BUG=skia:5043
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/e50f3e75392d7be8ae89df8f55b1700100c34ad7
==========

[commit-bot: I haz the power, 2016-03-28 14:03:11]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/e50f3e75392d7be8ae89df8f55b1700100c34ad7

[jvanverth1, 2016-03-28 16:23:27]

On 2016/03/28 13:52:05, jvanverth1 wrote:
> On 2016/03/28 13:38:12, bsalomon wrote:
> > Ok, I think the VkInterface should be stuff that we need to run Ganesh, not
> > stuff just required by our test tools. Presumably clients will do their own
> > windowing system integration.
> 
> Wait, doesn't nanobench get windowing through SkGLContext? That's in
src/gpu/gl,
> and the platform-specific code is under that. The other thing is that other
than
> the handful of platform-specific calls, windowing and swapchain setup is the
> same on all platforms. Or do you just want to keep it out of the public
header?

NM, I forgot you were moving SkGLContext to tools/gpu/gl.