Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(58)

Issue 18345020: Correctly release resources in xdisplaycheck. (Closed)

Created:
6 years, 1 month ago by Alexander Potapenko
Modified:
6 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews
Visibility:
Public.

Description

Correctly release resources in xdisplaycheck. Fix a memory leak in xdisplaycheck that causes the LeakSanitizer bot to fail. Patch by Sergey Matveev (earthdok@chromium.org) BUG=NONE R=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210192

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M tools/xdisplaycheck/xdisplaycheck.cc View 1 3 chunks +26 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexander Potapenko
This is a copy of https://codereview.chromium.org/18305006/, but Sergey was unable to land that patch, because ...
6 years, 1 month ago (2013-07-04 12:15:44 UTC) #1
Alexander Potapenko
PTAL
6 years, 1 month ago (2013-07-04 12:21:21 UTC) #2
sadrul
LGTM. With suggestion for improvement: https://codereview.chromium.org/18345020/diff/1/tools/xdisplaycheck/xdisplaycheck.cc File tools/xdisplaycheck/xdisplaycheck.cc (right): https://codereview.chromium.org/18345020/diff/1/tools/xdisplaycheck/xdisplaycheck.cc#newcode73 tools/xdisplaycheck/xdisplaycheck.cc:73: return -1; For completeness, ...
6 years, 1 month ago (2013-07-04 13:51:39 UTC) #3
earthdok
On 2013/07/04 13:51:39, sadrul wrote: > LGTM. With suggestion for improvement: > > https://codereview.chromium.org/18345020/diff/1/tools/xdisplaycheck/xdisplaycheck.cc > ...
6 years, 1 month ago (2013-07-04 14:04:04 UTC) #4
Alexander Potapenko
On 2013/07/04 13:51:39, sadrul wrote: > LGTM. With suggestion for improvement: > > https://codereview.chromium.org/18345020/diff/1/tools/xdisplaycheck/xdisplaycheck.cc > ...
6 years, 1 month ago (2013-07-04 14:17:20 UTC) #5
sadrul
SLGTM. Thanks earthdok@!
6 years, 1 month ago (2013-07-04 14:22:05 UTC) #6
Alexander Potapenko
6 years, 1 month ago (2013-07-04 15:22:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r210192 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698