Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18305006: Correctly release resources in xdisplaycheck. (Closed)

Created:
7 years, 5 months ago by earthdok
Modified:
7 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Correctly release resources in xdisplaycheck. Fix a memory leak in xdisplaycheck that causes the LeakSanitizer bot to fail. BUG=NONE R=glider@chromium.org

Patch Set 1 #

Patch Set 2 : use a scoped resource manager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M tools/xdisplaycheck/xdisplaycheck.cc View 1 3 chunks +26 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
earthdok
PTAL
7 years, 5 months ago (2013-07-04 11:16:19 UTC) #1
Alexander Potapenko
On 2013/07/04 11:16:19, earthdok wrote: > PTAL LGTM
7 years, 5 months ago (2013-07-04 11:19:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/18305006/1
7 years, 5 months ago (2013-07-04 11:19:33 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-04 11:47:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/18305006/1
7 years, 5 months ago (2013-07-04 11:56:22 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-04 12:10:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/18305006/15001
7 years, 5 months ago (2013-07-04 14:16:57 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-04 15:05:03 UTC) #8
earthdok
7 years, 5 months ago (2013-07-04 15:38:47 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698