Correctly release resources in xdisplaycheck.

tools/xdisplaycheck/xdisplaycheck.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This is a small program that tries to connect to the X server.  It
 // continually retries until it connects or 30 seconds pass.  If it fails
 // to connect to the X server or fails to find needed functiona, it returns
 // an error code of -1.
 //
 // This is to help verify that a useful X server is available before we start
@@ skipping 23 matching lines @@
     sleep_time = remaining;
 }
 
 int main(int argc, char* argv[]) {
   Display* display = NULL;
   if (argv[1] && strcmp(argv[1], "--noserver") == 0) {
     display = XOpenDisplay(NULL);
     if (display) {
       fprintf(stderr, "Found unexpected connectable display %s\n",
               XDisplayName(NULL));
+      XCloseDisplay(display);
     }
     // Return success when we got an unexpected display so that the code
     // without the --noserver is the same, but slow, rather than inverted.
     return !display;
   }
 
   int kNumTries = 78;  // 78*77/2 * 10 = 30s of waiting
   int tries;
   for (tries = 0; tries < kNumTries; ++tries) {
     display = XOpenDisplay(NULL);
     if (display)
       break;
     Sleep(10 * tries);
   }
 
   if (!display) {
     fprintf(stderr, "Failed to connect to %s\n", XDisplayName(NULL));
     return -1;
   }
 
   fprintf(stderr, "Connected after %d retries\n", tries);
 
 #if defined(USE_AURA)
   // Check for XInput2
   int opcode, event, err;
   if (!XQueryExtension(display, "XInputExtension", &opcode, &event, &err)) {
     fprintf(stderr,
         "Failed to get XInputExtension on %s.\n", XDisplayName(NULL));
     return -1;

[sadrul, 2013/07/04 13:51:39]

For completeness, you should XCloseDisplay(display) here and in line 80 too?

How about introduce a class that cleans up the display in the destructor, like
so:

class XScopedDisplay {
 public:
  XScopedDisplay() : display_(NULL) {}
  ~XScopedDisplay() {
    if (display_) XCloseDisplay(display_);
  }

  void set(Display* display) { display_ = display; }
  Display* display() { return display_; }

 private:
  Display* display_;
}

This way, you don't have to keep track of every returns and XCloseDisplay from
there.

   }
 
   int major = 2, minor = 0;
   if (XIQueryVersion(display, &major, &minor) == BadRequest) {
     fprintf(stderr,
         "Server does not have XInput2 on %s.\n", XDisplayName(NULL));
     return -1;
   }
 
   // Ask for the list of devices. This can cause some Xvfb to crash.
   int count = 0;
   XIDeviceInfo* devices = XIQueryDevice(display, XIAllDevices, &count);
   if (devices)
     XIFreeDeviceInfo(devices);
 
   fprintf(stderr,
       "XInput2 verified initially sane on %s.\n", XDisplayName(NULL));
 #endif
-
+  if (display)
+    XCloseDisplay(display);
   return 0;
 }