Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1834203003: Revert of Refine ash shelf tooltip closing on non-mash ChromeOS. (Closed)

Created:
4 years, 8 months ago by msw
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refine ash shelf tooltip closing on non-mash ChromeOS. (patchset #5 id:80001 of https://codereview.chromium.org/1828133004/ ) Reason for revert: ash_unittests ShelfLayoutManagerTest.ShutdownHandlesWindowActivation failure on win: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/47284 Original issue's description: > Refine ash shelf tooltip closing on non-mash ChromeOS. > > Fixes a regression from: https://codereview.chromium.org/1816753002 > Also reverse expected behavior for touching tooltips. > (closes on stable, tests expected them to stay open...) > > Inline bubble function definitions. > Call WillDeleteShelf earlier to fix a test crash... > TODO: Encapsulate more ShelfLayoutManager code. > > BUG=595853 > TEST=ChromeOS tooltips stay open on hover; close for external touches. > R=sky@chromium.org > > Committed: https://crrev.com/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24 > Cr-Commit-Position: refs/heads/master@{#383404} > > Committed: https://crrev.com/c2aa7f5e8870c04c8aff0fd5da27820636e53e38 > Cr-Commit-Position: refs/heads/master@{#383579} TBR=sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595853 Committed: https://crrev.com/327ea5e179d66d730bd6e03486b3494660d84dbc Cr-Commit-Position: refs/heads/master@{#383622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -90 lines) Patch
M ash/shelf/shelf_layout_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_tooltip_manager.cc View 5 chunks +60 lines, -56 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager_unittest.cc View 1 chunk +23 lines, -29 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
msw
Created Revert of Refine ash shelf tooltip closing on non-mash ChromeOS.
4 years, 8 months ago (2016-03-29 00:04:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834203003/1
4 years, 8 months ago (2016-03-29 00:04:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 00:04:55 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 00:07:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/327ea5e179d66d730bd6e03486b3494660d84dbc
Cr-Commit-Position: refs/heads/master@{#383622}

Powered by Google App Engine
This is Rietveld 408576698