DescriptionRevert of Refine ash shelf tooltip closing on non-mash ChromeOS. (patchset #5 id:80001 of https://codereview.chromium.org/1828133004/ )
Reason for revert:
ash_unittests ShelfLayoutManagerTest.ShutdownHandlesWindowActivation failure on win:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/47284
Original issue's description:
> Refine ash shelf tooltip closing on non-mash ChromeOS.
>
> Fixes a regression from: https://codereview.chromium.org/1816753002
> Also reverse expected behavior for touching tooltips.
> (closes on stable, tests expected them to stay open...)
>
> Inline bubble function definitions.
> Call WillDeleteShelf earlier to fix a test crash...
> TODO: Encapsulate more ShelfLayoutManager code.
>
> BUG=595853
> TEST=ChromeOS tooltips stay open on hover; close for external touches.
> R=sky@chromium.org
>
> Committed: https://crrev.com/1a0d283fa81e19b47fb85523f28c4a03f7dc1d24
> Cr-Commit-Position: refs/heads/master@{#383404}
>
> Committed: https://crrev.com/c2aa7f5e8870c04c8aff0fd5da27820636e53e38
> Cr-Commit-Position: refs/heads/master@{#383579}
TBR=sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=595853
Committed: https://crrev.com/327ea5e179d66d730bd6e03486b3494660d84dbc
Cr-Commit-Position: refs/heads/master@{#383622}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|