Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: ash/shelf/shelf_tooltip_manager_unittest.cc

Issue 1834203003: Revert of Refine ash shelf tooltip closing on non-mash ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/shelf/shelf_tooltip_manager.cc ('k') | ash/shelf/shelf_widget.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shelf/shelf_tooltip_manager.h" 5 #include "ash/shelf/shelf_tooltip_manager.h"
6 6
7 #include "ash/shelf/shelf_layout_manager.h" 7 #include "ash/shelf/shelf_layout_manager.h"
8 #include "ash/shelf/shelf_widget.h" 8 #include "ash/shelf/shelf_widget.h"
9 #include "ash/shell.h" 9 #include "ash/shell.h"
10 #include "ash/shell_window_ids.h" 10 #include "ash/shell_window_ids.h"
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 generator.PressTouch(); 166 generator.PressTouch();
167 EXPECT_FALSE(TooltipIsVisible()); 167 EXPECT_FALSE(TooltipIsVisible());
168 168
169 // Should hide for gesture events in the shelf. 169 // Should hide for gesture events in the shelf.
170 ShowImmediately(); 170 ShowImmediately();
171 ASSERT_TRUE(TooltipIsVisible()); 171 ASSERT_TRUE(TooltipIsVisible());
172 generator.GestureTapDownAndUp(shelf_bounds.CenterPoint()); 172 generator.GestureTapDownAndUp(shelf_bounds.CenterPoint());
173 EXPECT_FALSE(TooltipIsVisible()); 173 EXPECT_FALSE(TooltipIsVisible());
174 } 174 }
175 175
176 TEST_F(ShelfTooltipManagerTest, HideForExternalEvents) { 176 // TODO(msw): Hiding for touch and gesture events outside the shelf is broken.
177 TEST_F(ShelfTooltipManagerTest, HideForEventsBroken) {
177 ui::test::EventGenerator generator(ash::Shell::GetPrimaryRootWindow()); 178 ui::test::EventGenerator generator(ash::Shell::GetPrimaryRootWindow());
178 // TODO(msw): Observe events outside the shelf in mash, to close tooltips.
179 aura::Window* shelf_window = shelf_->shelf_widget()->GetNativeWindow();
180 bool closes = shelf_window->GetRootWindow() == Shell::GetPrimaryRootWindow();
181 179
182 // Should hide for touches outside the shelf.
183 ShowImmediately(); 180 ShowImmediately();
184 ASSERT_TRUE(TooltipIsVisible()); 181 ASSERT_TRUE(TooltipIsVisible());
182
185 generator.set_current_location(gfx::Point()); 183 generator.set_current_location(gfx::Point());
186 generator.PressTouch(); 184 generator.PressTouch();
187 EXPECT_EQ(TooltipIsVisible(), !closes); 185 EXPECT_TRUE(TooltipIsVisible());
188 186
189 // Should hide for touch events on the tooltip.
190 ShowImmediately();
191 ASSERT_TRUE(TooltipIsVisible());
192 generator.set_current_location(GetTooltipWindow()->bounds().CenterPoint());
193 generator.PressTouch();
194 EXPECT_EQ(TooltipIsVisible(), !closes);
195
196 // Should hide for gestures outside the shelf.
197 ShowImmediately();
198 ASSERT_TRUE(TooltipIsVisible());
199 generator.GestureTapDownAndUp(gfx::Point()); 187 generator.GestureTapDownAndUp(gfx::Point());
200 EXPECT_EQ(TooltipIsVisible(), !closes);
201 }
202
203 TEST_F(ShelfTooltipManagerTest, DoNotHideForKeyEvents) {
204 ui::test::EventGenerator generator(ash::Shell::GetPrimaryRootWindow());
205
206 // Should not hide for key events.
207 ShowImmediately();
208 ASSERT_TRUE(TooltipIsVisible());
209 generator.PressKey(ui::VKEY_A, ui::EF_NONE);
210 EXPECT_TRUE(TooltipIsVisible()); 188 EXPECT_TRUE(TooltipIsVisible());
211 } 189 }
212 190
191 TEST_F(ShelfTooltipManagerTest, DoNotHideForEvents) {
192 ui::test::EventGenerator generator(ash::Shell::GetPrimaryRootWindow());
193
194 ShowImmediately();
195 ASSERT_TRUE(TooltipIsVisible());
196
197 // Should not hide for key events.
198 generator.PressKey(ui::VKEY_A, ui::EF_NONE);
199 EXPECT_TRUE(TooltipIsVisible());
200
201 // Should not hide for touch events on the tooltip.
202 generator.set_current_location(GetTooltipWindow()->bounds().CenterPoint());
203 generator.PressTouch();
204 EXPECT_TRUE(TooltipIsVisible());
205 }
206
213 } // namespace test 207 } // namespace test
214 } // namespace ash 208 } // namespace ash
OLDNEW
« no previous file with comments | « ash/shelf/shelf_tooltip_manager.cc ('k') | ash/shelf/shelf_widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698