ash/shelf/shelf_layout_manager.cc - Issue 1834203003: Revert of Refine ash shelf tooltip closing on non-mash ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/shelf_layout_manager.cc

Issue 1834203003: Revert of Refine ash shelf tooltip closing on non-mash ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shelf/shelf_layout_manager.cc

diff --git a/ash/shelf/shelf_layout_manager.cc b/ash/shelf/shelf_layout_manager.cc

index 5d70e8df6d807c83d8d83e9d2fd451912e472110..f27899c85eab8aca4fbeb100e15d5f150ff5faf6 100644

--- a/ash/shelf/shelf_layout_manager.cc

+++ b/ash/shelf/shelf_layout_manager.cc

@@ -236,7 +236,6 @@

// Stop observing window change, otherwise we can attempt to update a

// partially destructed shelf.

aura::client::GetActivationClient(root_window_)->RemoveObserver(this);

- FOR_EACH_OBSERVER(ShelfLayoutManagerObserver, observers_, WillDeleteShelf());

}

bool ShelfLayoutManager::IsVisible() const {

« no previous file with comments | « no previous file | ash/shelf/shelf_tooltip_manager.cc » ('j') | no next file with comments »