Issue 18341007: Minor GrContext/GrInOrderDrawBuffer cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18341007: Minor GrContext/GrInOrderDrawBuffer cleanup (Closed)

Created:
7 years, 5 months ago by robertphillips

Modified:
7 years, 5 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

In preparation for having the ResourceCache be able to flush the draw buffer

Patch Set 1 #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -31 lines)			Patch
M	include/gpu/GrContext.h	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	2 chunks	+1 line, -12 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	2 chunks	+6 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm with one question https://codereview.chromium.org/18341007/diff/1/src/gpu/GrInOrderDrawBuffer.cpp File src/gpu/GrInOrderDrawBuffer.cpp (left): https://codereview.chromium.org/18341007/diff/1/src/gpu/GrInOrderDrawBuffer.cpp#oldcode456 src/gpu/GrInOrderDrawBuffer.cpp:456: GrAssert(!fFlushing); Is this assertion no ...

7 years, 5 months ago (2013-07-03 18:34:21 UTC) #2

robertphillips

7 years, 5 months ago (2013-07-03 18:37:45 UTC) #3

Message was sent while issue was closed.

committed as r9898

https://codereview.chromium.org/18341007/diff/1/src/gpu/GrInOrderDrawBuffer.cpp
File src/gpu/GrInOrderDrawBuffer.cpp (left):

https://codereview.chromium.org/18341007/diff/1/src/gpu/GrInOrderDrawBuffer.c...
src/gpu/GrInOrderDrawBuffer.cpp:456: GrAssert(!fFlushing);
It shouldn't ever fire since we are returning at the top of the function if
we're flushing.

Expand Messages | Collapse Messages