Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1833523002: Migrate content/*/p2p/* code to net::IPAddress. (Closed)

Created:
4 years, 9 months ago by martijnc
Modified:
4 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate content/*/p2p/* code to net::IPAddress. BUG=496258 Committed: https://crrev.com/92c439fbcf4850b1ea8f90d80074e9150ab94f42 Cr-Commit-Position: refs/heads/master@{#383287}

Patch Set 1 : #

Total comments: 3

Patch Set 2 : comments sergeyu #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -102 lines) Patch
M content/browser/renderer_host/p2p/socket_dispatcher_host.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 3 chunks +10 lines, -15 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_test_utils.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/common/p2p_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.h View 2 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.cc View 1 6 chunks +8 lines, -10 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager_unittest.cc View 3 chunks +19 lines, -35 lines 0 comments Download
M content/renderer/p2p/ipc_socket_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/network_list_observer.h View 2 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/p2p/socket_dispatcher.h View 2 chunks +3 lines, -6 lines 0 comments Download
M content/renderer/p2p/socket_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/glue/chrome_async_socket_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M jingle/glue/fake_ssl_client_socket_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M jingle/glue/proxy_resolving_client_socket.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M jingle/glue/utils.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M jingle/glue/utils.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
martijnc
sergeyu: can you take a look at the p2p and jingle changes? dcheng: can you ...
4 years, 9 months ago (2016-03-24 20:38:16 UTC) #5
Sergey Ulanov
lgtm after my nit about function name is addressed. https://codereview.chromium.org/1833523002/diff/20001/jingle/glue/utils.h File jingle/glue/utils.h (right): https://codereview.chromium.org/1833523002/diff/20001/jingle/glue/utils.h#newcode35 jingle/glue/utils.h:35: ...
4 years, 9 months ago (2016-03-24 20:45:45 UTC) #6
eroman
lgtm
4 years, 9 months ago (2016-03-24 21:36:04 UTC) #7
dcheng
lgtm
4 years, 9 months ago (2016-03-24 21:58:48 UTC) #8
martijnc
https://codereview.chromium.org/1833523002/diff/20001/jingle/glue/utils.h File jingle/glue/utils.h (right): https://codereview.chromium.org/1833523002/diff/20001/jingle/glue/utils.h#newcode35 jingle/glue/utils.h:35: rtc::IPAddress NetIPAddressToIPAddress(const net::IPAddress& ip_address); On 2016/03/24 at 20:45:45, Sergey ...
4 years, 9 months ago (2016-03-25 16:01:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833523002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833523002/40001
4 years, 9 months ago (2016-03-25 16:01:15 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-25 16:48:52 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 16:49:53 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92c439fbcf4850b1ea8f90d80074e9150ab94f42
Cr-Commit-Position: refs/heads/master@{#383287}

Powered by Google App Engine
This is Rietveld 408576698