Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: content/browser/renderer_host/p2p/socket_dispatcher_host.cc

Issue 1833523002: Migrate content/*/p2p/* code to net::IPAddress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments sergeyu Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/p2p/socket_dispatcher_host.cc
diff --git a/content/browser/renderer_host/p2p/socket_dispatcher_host.cc b/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
index 26cbb00c47f8d1029a8402c76f6f11703cfddce8..b1bc3c3c4f2c7602cbbd4981b06b2735b293c33a 100644
--- a/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
+++ b/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
@@ -14,7 +14,6 @@
#include "content/public/browser/resource_context.h"
#include "net/base/address_list.h"
#include "net/base/completion_callback.h"
-#include "net/base/ip_address_number.h"
#include "net/base/net_errors.h"
#include "net/base/network_interfaces.h"
#include "net/base/sys_addrinfo.h"
@@ -346,14 +345,13 @@ void P2PSocketDispatcherHost::DoGetNetworkList() {
void P2PSocketDispatcherHost::SendNetworkList(
const net::NetworkInterfaceList& list,
- const net::IPAddressNumber& default_ipv4_local_address,
- const net::IPAddressNumber& default_ipv6_local_address) {
+ const net::IPAddress& default_ipv4_local_address,
+ const net::IPAddress& default_ipv6_local_address) {
Send(new P2PMsg_NetworkListChanged(list, default_ipv4_local_address,
default_ipv6_local_address));
}
-net::IPAddressNumber P2PSocketDispatcherHost::GetDefaultLocalAddress(
- int family) {
+net::IPAddress P2PSocketDispatcherHost::GetDefaultLocalAddress(int family) {
DCHECK(family == AF_INET || family == AF_INET6);
// Creation and connection of a UDP socket might be janky.
@@ -364,25 +362,22 @@ net::IPAddressNumber P2PSocketDispatcherHost::GetDefaultLocalAddress(
net::DatagramSocket::DEFAULT_BIND, net::RandIntCallback(), NULL,
net::NetLog::Source()));
- net::IPAddressNumber ip_address_number;
+ net::IPAddress ip_address;
if (family == AF_INET) {
- ip_address_number.assign(kPublicIPv4Host,
- kPublicIPv4Host + net::kIPv4AddressSize);
+ ip_address = net::IPAddress(kPublicIPv4Host);
} else {
- ip_address_number.assign(kPublicIPv6Host,
- kPublicIPv6Host + net::kIPv6AddressSize);
+ ip_address = net::IPAddress(kPublicIPv6Host);
}
- if (socket->Connect(net::IPEndPoint(ip_address_number, kPublicPort)) !=
- net::OK) {
- return net::IPAddressNumber();
+ if (socket->Connect(net::IPEndPoint(ip_address, kPublicPort)) != net::OK) {
+ return net::IPAddress();
}
net::IPEndPoint local_address;
if (socket->GetLocalAddress(&local_address) != net::OK)
- return net::IPAddressNumber();
+ return net::IPAddress();
- return local_address.address().bytes();
+ return local_address.address();
}
void P2PSocketDispatcherHost::OnAddressResolved(

Powered by Google App Engine
This is Rietveld 408576698