Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Unified Diff: content/renderer/p2p/ipc_network_manager_unittest.cc

Issue 1833523002: Migrate content/*/p2p/* code to net::IPAddress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments sergeyu Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/p2p/ipc_network_manager.cc ('k') | content/renderer/p2p/ipc_socket_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/p2p/ipc_network_manager_unittest.cc
diff --git a/content/renderer/p2p/ipc_network_manager_unittest.cc b/content/renderer/p2p/ipc_network_manager_unittest.cc
index 31fcd472a0de6ecae29414c08eceb5eb9d1087df..fb87c9e560c389ac84288589665d77889e814c34 100644
--- a/content/renderer/p2p/ipc_network_manager_unittest.cc
+++ b/content/renderer/p2p/ipc_network_manager_unittest.cc
@@ -5,7 +5,7 @@
#include "base/memory/scoped_ptr.h"
#include "content/renderer/p2p/ipc_network_manager.h"
#include "content/renderer/p2p/network_list_manager.h"
-#include "net/base/ip_address_number.h"
+#include "net/base/ip_address.h"
#include "net/base/network_change_notifier.h"
#include "net/base/network_interfaces.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -53,33 +53,23 @@ class IpcNetworkManagerTest : public testing::Test {
// issue 19249005 integrated into chromium
TEST_F(IpcNetworkManagerTest, TestMergeNetworkList) {
net::NetworkInterfaceList list;
- net::IPAddressNumber ip_number;
+ net::IPAddress ip;
std::vector<rtc::Network*> networks;
rtc::IPAddress ip_address;
// Add 2 networks with the same prefix and prefix length.
- EXPECT_TRUE(net::ParseIPLiteralToNumber(kIPv6PublicAddrString1, &ip_number));
- list.push_back(
- net::NetworkInterface("em1",
- "em1",
- 0,
- net::NetworkChangeNotifier::CONNECTION_UNKNOWN,
- ip_number,
- 64,
- net::IP_ADDRESS_ATTRIBUTE_NONE));
-
- EXPECT_TRUE(net::ParseIPLiteralToNumber(kIPv6PublicAddrString2, &ip_number));
- list.push_back(
- net::NetworkInterface("em1",
- "em1",
- 0,
- net::NetworkChangeNotifier::CONNECTION_UNKNOWN,
- ip_number,
- 64,
- net::IP_ADDRESS_ATTRIBUTE_NONE));
-
- network_manager_->OnNetworkListChanged(list, net::IPAddressNumber(),
- net::IPAddressNumber());
+ EXPECT_TRUE(ip.AssignFromIPLiteral(kIPv6PublicAddrString1));
+ list.push_back(net::NetworkInterface(
+ "em1", "em1", 0, net::NetworkChangeNotifier::CONNECTION_UNKNOWN, ip, 64,
+ net::IP_ADDRESS_ATTRIBUTE_NONE));
+
+ EXPECT_TRUE(ip.AssignFromIPLiteral(kIPv6PublicAddrString2));
+ list.push_back(net::NetworkInterface(
+ "em1", "em1", 0, net::NetworkChangeNotifier::CONNECTION_UNKNOWN, ip, 64,
+ net::IP_ADDRESS_ATTRIBUTE_NONE));
+
+ network_manager_->OnNetworkListChanged(list, net::IPAddress(),
+ net::IPAddress());
network_manager_->GetNetworks(&networks);
EXPECT_EQ(1uL, networks.size());
EXPECT_EQ(2uL, networks[0]->GetIPs().size());
@@ -87,19 +77,13 @@ TEST_F(IpcNetworkManagerTest, TestMergeNetworkList) {
// Add another network with different prefix length, should result in
// a different network.
networks.clear();
- list.push_back(
- net::NetworkInterface("em1",
- "em1",
- 0,
- net::NetworkChangeNotifier::CONNECTION_UNKNOWN,
- ip_number,
- 48,
- net::IP_ADDRESS_ATTRIBUTE_NONE));
+ list.push_back(net::NetworkInterface(
+ "em1", "em1", 0, net::NetworkChangeNotifier::CONNECTION_UNKNOWN, ip, 48,
+ net::IP_ADDRESS_ATTRIBUTE_NONE));
// Push an unknown address as the default address.
- EXPECT_TRUE(net::ParseIPLiteralToNumber(kIPv4MappedAddrString, &ip_number));
- network_manager_->OnNetworkListChanged(list, net::IPAddressNumber(),
- ip_number);
+ EXPECT_TRUE(ip.AssignFromIPLiteral(kIPv4MappedAddrString));
+ network_manager_->OnNetworkListChanged(list, net::IPAddress(), ip);
// The unknown default address should be ignored.
EXPECT_FALSE(network_manager_->GetDefaultLocalAddress(AF_INET6, &ip_address));
« no previous file with comments | « content/renderer/p2p/ipc_network_manager.cc ('k') | content/renderer/p2p/ipc_socket_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698