Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1833193002: Content "gn check" work. (Closed)

Created:
4 years, 9 months ago by brettw
Modified:
4 years, 9 months ago
Reviewers:
jschuh, jam
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, tracing+reviews_chromium.org, ben+mojo_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, kalyank, mlamouri+watch-content_chromium.org, tdresser+watch_chromium.org, Peter Beverloo, feature-media-reviews_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, rjkroege, wfh+watch_chromium.org, Aaron Boodman, mkwst+moarreviews-renderer_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Content "gn check" work. Make content/gpu and content/plugin pass GN check. Significant work for most of content/test Makes most of content/shell and content/test pass check. These are not all enabled yet pending a few remaining issues that are more difficult to solve. The private content targets now allow content/test to include headers from them for non-component builds. Checking is disabled for content/test in component builds as described in the comment at the top of //content/BUILD.gn Renames the ui/events/ipc according to GN style. Annotates all content and gpu visibility declarations with why the're there, and fixes some incorrect ones that people added without understanding. Reland of https://codereview.chromium.org/1828483002/ with significant changes. TBR=jschuh (non-security-sensitive ipc build changes) Committed: https://crrev.com/b78fc9e5f3b3cb1fc96c50b89a3a6c7f23accee7 Cr-Commit-Position: refs/heads/master@{#383358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -53 lines) Patch
M .gn View 1 chunk +13 lines, -0 lines 0 comments Download
M components/crash/content/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/BUILD.gn View 2 chunks +18 lines, -0 lines 0 comments Download
M content/app/BUILD.gn View 1 chunk +14 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 3 chunks +15 lines, -2 lines 0 comments Download
M content/browser/tracing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/child/BUILD.gn View 2 chunks +13 lines, -4 lines 0 comments Download
M content/common/BUILD.gn View 3 chunks +22 lines, -4 lines 0 comments Download
M content/gpu/BUILD.gn View 5 chunks +14 lines, -5 lines 0 comments Download
M content/plugin/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M content/ppapi_plugin/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M content/public/browser/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/child/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/gpu/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M content/public/plugin/BUILD.gn View 2 chunks +8 lines, -1 line 0 comments Download
M content/public/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/utility/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 5 chunks +17 lines, -3 lines 0 comments Download
M content/renderer/mus/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M content/shell/BUILD.gn View 6 chunks +13 lines, -2 lines 0 comments Download
M content/test/BUILD.gn View 31 chunks +126 lines, -9 lines 0 comments Download
M content/utility/BUILD.gn View 3 chunks +17 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 chunk +3 lines, -4 lines 0 comments Download
M gpu/config/BUILD.gn View 1 chunk +3 lines, -4 lines 0 comments Download
M gpu/ipc/common/BUILD.gn View 3 chunks +6 lines, -1 line 0 comments Download
M media/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/gles2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/shared_impl/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ipc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
brettw
4 years, 9 months ago (2016-03-25 19:52:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833193002/1
4 years, 9 months ago (2016-03-25 19:53:10 UTC) #6
jam
lgtm
4 years, 9 months ago (2016-03-25 20:21:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833193002/1
4 years, 9 months ago (2016-03-25 20:23:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 21:03:00 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 21:04:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b78fc9e5f3b3cb1fc96c50b89a3a6c7f23accee7
Cr-Commit-Position: refs/heads/master@{#383358}

Powered by Google App Engine
This is Rietveld 408576698