Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: content/browser/BUILD.gn

Issue 1833193002: Content "gn check" work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/app/BUILD.gn ('k') | content/browser/tracing/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/BUILD.gn
diff --git a/content/browser/BUILD.gn b/content/browser/BUILD.gn
index 9245309c446ae1210785fe541c47b04c666a6d82..fb8d3a92e458b4ff7980755a61ed40aeaf2abb37 100644
--- a/content/browser/BUILD.gn
+++ b/content/browser/BUILD.gn
@@ -11,7 +11,10 @@ import("//mojo/public/mojo_application_manifest.gni")
source_set("browser") {
# Only the public target should depend on this. All other targets (even
# internal content ones) should depend on the public one.
- visibility = [ "//content/public/browser:browser_sources" ]
+ visibility = [
+ ":for_content_tests", # See top of //content/BUILD.gn for why.
+ "//content/public/browser:browser_sources",
+ ]
configs += [
"//build/config:precompiled_headers",
@@ -48,7 +51,7 @@ source_set("browser") {
"//content/browser/notifications:notification_proto",
"//content/browser/service_worker:service_worker_proto",
"//content/browser/speech/proto",
- "//content/common:mojo_bindings",
+ "//content/common",
"//content/public/common:common_sources",
"//content/public/common:mojo_bindings",
"//crypto",
@@ -526,6 +529,16 @@ source_set("browser") {
}
}
+# See comment at the top of //content/BUILD.gn for how this works.
+group("for_content_tests") {
+ visibility = [ "//content/test/*" ]
+ if (!is_component_build) {
+ public_deps = [
+ ":browser",
+ ]
+ }
+}
+
mojo_application_manifest("chrome_manifest") {
type = "exe"
application_name = "chrome"
« no previous file with comments | « content/app/BUILD.gn ('k') | content/browser/tracing/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698