Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2178)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/public/browser/BUILD.gn

Issue 1833193002: Content "gn check" work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/ppapi_plugin/BUILD.gn ('k') | content/public/child/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/BUILD.gn
diff --git a/content/public/browser/BUILD.gn b/content/public/browser/BUILD.gn
index 643cb8f7436abd68cedfbcfe8d55da4acfe7cd1a..5b04b1e5ad3c9e20ea802dbe6070080bd1ad5bba 100644
--- a/content/public/browser/BUILD.gn
+++ b/content/public/browser/BUILD.gn
@@ -19,6 +19,7 @@ group("browser") {
}
source_set("browser_sources") {
+ # External code should depend on via ":browser" above.
visibility = [ "//content/*" ]
sources = rebase_path(content_browser_gypi_values.public_browser_sources,
@@ -40,7 +41,7 @@ source_set("browser_sources") {
]
deps = [
"//cc",
- "//content/browser",
+ "//content/browser", # Must not be public_deps!
"//content/public/common:common_sources",
"//gpu",
"//media",
« no previous file with comments | « content/ppapi_plugin/BUILD.gn ('k') | content/public/child/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698