chrome/browser/password_manager/chrome_password_manager_client.h - Issue 1832933002: Update the |skip_zero_click| flag of a credential when selected in the account chooser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 1832933002: Update the |skip_zero_click| flag of a credential when selected in the account chooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/account_chooser_dialog_android.cc ('k') | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.h

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h

index 8d0f0239e48389e43121e3097e9c1c5275c77d8d..ffe628ad4aa21eecadd0fae82dab5307357ae155 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.h

+++ b/chrome/browser/password_manager/chrome_password_manager_client.h

@@ -58,8 +58,7 @@ class ChromePasswordManagerClient

ScopedVector<autofill::PasswordForm> local_forms,

ScopedVector<autofill::PasswordForm> federated_forms,

const GURL& origin,

- base::Callback<void(const password_manager::CredentialInfo&)> callback)

- override;

+ const CredentialsCallback& callback) override;

void ForceSavePassword() override;

void GeneratePassword() override;

void NotifyUserAutoSignin(

@@ -155,10 +154,10 @@ class ChromePasswordManagerClient

// for UMA stats.

void GenerationAvailableForForm(const autofill::PasswordForm& form);

- // Called as a response to PromptUserToChooseCredentials.

- void OnCredentialsChosen(

- base::Callback<void(const password_manager::CredentialInfo&)> callback,

- const password_manager::CredentialInfo& credential);

+ // Called as a response to PromptUserToChooseCredentials. nullptr means that

+ // nothing was chosen.

+ void OnCredentialsChosen(const CredentialsCallback& callback,

+ const autofill::PasswordForm* form);

Profile* const profile_;