Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6722)

Unified Diff: chrome/browser/password_manager/account_chooser_dialog_android.cc

Issue 1832933002: Update the |skip_zero_click| flag of a credential when selected in the account chooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/account_chooser_dialog_android.cc
diff --git a/chrome/browser/password_manager/account_chooser_dialog_android.cc b/chrome/browser/password_manager/account_chooser_dialog_android.cc
index 309253f363263530a592c4d11b5644365a3fe17c..2df638258e2d0c113f0f933c3bc2640e1e10238a 100644
--- a/chrome/browser/password_manager/account_chooser_dialog_android.cc
+++ b/chrome/browser/password_manager/account_chooser_dialog_android.cc
@@ -206,17 +206,16 @@ void AccountChooserDialogAndroid::ChooseCredential(
password_manager::CredentialType type) {
using namespace password_manager;
if (type == CredentialType::CREDENTIAL_TYPE_EMPTY) {
- passwords_data_.ChooseCredential(autofill::PasswordForm(), type);
+ passwords_data_.ChooseCredential(nullptr);
return;
}
- DCHECK(type == CredentialType::CREDENTIAL_TYPE_PASSWORD ||
- type == CredentialType::CREDENTIAL_TYPE_FEDERATED);
+ DCHECK_EQ(CredentialType::CREDENTIAL_TYPE_PASSWORD, type);
const auto& credentials_forms =
(type == CredentialType::CREDENTIAL_TYPE_PASSWORD)
? local_credentials_forms()
: federated_credentials_forms();
if (index < credentials_forms.size()) {
- passwords_data_.ChooseCredential(*credentials_forms[index], type);
+ passwords_data_.ChooseCredential(credentials_forms[index]);
}
}
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698